Refactor tests of BlockMachineProcessor
#2276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
commented
Dec 20, 2024
| let machines = MachineExtractor::new(&fixed_data).split_out_machines(retained_identities); | ||
| let mutable_state = MutableState::new(machines.into_iter(), &|_| { | ||
| Err("Query not implemented".to_string()) | ||
| }); |
There was a problem hiding this comment.
I tried to extract this block as a function, but it doesn't compile...
georgwiese
changed the title
BlockMachineProcessor
This was referenced Dec 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
Pulled out of #2276. Needed to make the code generated for the Binary machine compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we expect a "main" machine with a connecting identity to the block machine, and run the "normal" machine extractor on the entire PIL.
Besides reducing the amount of code, this gives us more objects, like
MutableState.