Modified the audit log file name and Added deletion of empty file #503
Conversation
ppc64le-cloud-bot
added
the
size/S
KeerthanaAP
force-pushed
the
audit_log
branch
from
517aecc to
4b1b16b
Compare
pkg/audit/audit.go
Outdated
| @@ -70,3 +71,10 @@ func (a *Audit) Log(name, op, value string) { | |||
| } | |||
| a.mutex.Unlock() | |||
| } | |||
|
|
|||
| func Delete(file string) { | |||
| check_file, _ := os.Stat(file) | |||
There was a problem hiding this comment.
what happens when file doesn't exist for some reason? its better to check for err and do nothing if error occurred.
pkg/audit/audit.go
Outdated
|
|
||
| func Delete(file string) { | ||
| check_file, _ := os.Stat(file) | ||
| if check_file.Size() == 0 && file == "pvsadm_audit.log" { |
There was a problem hiding this comment.
why do you wanna check the filename here?
There was a problem hiding this comment.
This is to delete the file only if its created by the tool and not to delete the user provided audit file.
There was a problem hiding this comment.
IMO its okay to delete the use provided as well if file is empty
There was a problem hiding this comment.
ok. will remove the condition and delete the user provided file as well.
KeerthanaAP
force-pushed
the
audit_log
branch
from
4b1b16b to
fdc739e
Compare
cmd/root.go
Outdated
| if err := rootCmd.Execute(); err != nil { | ||
| klog.Errorln(err) | ||
| audit.Delete(pkg.Options.AuditFile) |
There was a problem hiding this comment.
why are we calling this again if its already mentioned above as defer?
There was a problem hiding this comment.
As Defer will not be executed after os.Exit. we are calling the Delete explicitly before that.
There was a problem hiding this comment.
hmm..., lets handle the exit in the main() by returning err from here
KeerthanaAP
force-pushed
the
audit_log
branch
from
fdc739e to
659a068
Compare
cmd/root.go
Outdated
| if err := rootCmd.Execute(); err != nil { | ||
| klog.Errorln(err) | ||
| audit.Delete(pkg.Options.AuditFile) |
There was a problem hiding this comment.
hmm..., lets handle the exit in the main() by returning err from here
KeerthanaAP
force-pushed
the
audit_log
branch
from
659a068 to
797c524
Compare
ppc64le-cloud-bot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KeerthanaAP, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
Fix #152