Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud-config template made configurable. #509

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Cloud-config template made configurable. #509

merged 1 commit into from
Nov 9, 2023

Conversation

KeerthanaAP
Copy link
Contributor

Fix #86

Added cloud-config template option for user to override.

$pvsadm image qcow2ova  --image-name rhel-90-test --image-url /root/rhel-baseos-9.0-ppc64le-kvm.qcow2  --image-dist rhel --os-password TyBU84GrbPD75FsT --rhn-user rh-ee-sgokul --cloud-config user_cloud.config -v 3

I1107 09:06:42.446684 1016706 qcow2ova.go:96] Overriding with the user defined cloud config.
W1107 09:06:42.446804 1016706 qcow2ova.go:112] rhn-user and rhn-password options are mandatory when image-dist is rhel, please enter the details

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2023
mkumatag
mkumatag approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeerthanaAP, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 5997e7c into ppc64le-cloud:main Nov 9, 2023
3 checks passed
@KeerthanaAP KeerthanaAP deleted the cloud_config branch January 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose cloud-config template
3 participants
@KeerthanaAP @ppc64le-cloud-bot @mkumatag