-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate conditions immediately upon invocation. #678
Validate conditions immediately upon invocation. #678
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aman4433 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @aman4433! It looks like this is your first PR to ppc64le-cloud/pvsadm 🎉 |
Hi @aman4433. Thanks for your PR. I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c77e17b
to
85c06be
Compare
/ok-to-test |
Superseded #680 |
@kishen-v: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fixes : #676
Validate conditions immediately upon invocation.