GA minor fixes (#244)

* fix docstring nested FitGenetic.run * fix lr + balance fraction num_neurons GA
ppdebreuck · Nov 13, 2024 · 7ee7d8b · 7ee7d8b
1 parent 53a9a6b
commit 7ee7d8b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/modnet/hyper_opt/fit_genetic.py b/modnet/hyper_opt/fit_genetic.py
@@ -52,7 +52,8 @@ def __init__(
         self.xscale_before_impute = True
         self.lr_list = [0.1, 0.01, 0.005, 0.001]
         self.batch_size_list = [32, 64, 128, 256]
-        self.fraction_list = [1, 0.75, 0.5, 0.25]
+        self.fraction_list = [1, 1, 0.75, 0.5, 0.25]
+        # add 1 to balance the chance of having an architecture with the same num_neurons on each layer
 
         if fit_params:
             self.__dict__.update(fit_params)

diff --git a/modnet/models/ensemble.py b/modnet/models/ensemble.py
@@ -510,7 +510,7 @@ def _validate_ensemble_model(
 
     model.fit(
         train_data,
-        learning_rate=lr,
+        lr=lr,
         epochs=epochs,
         batch_size=batch_size,
         loss=loss,
@@ -522,7 +522,7 @@ def _validate_ensemble_model(
         val_data=val_data,
     )
 
-    learning_curves = [m.history["val_loss"] for m in model.model]
+    learning_curves = [m.history["val_loss"] for m in model.models]
 
     val_loss = model.evaluate(val_data)