Bundle recent deps updates #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [pandas](https://github.com/pandas-dev/pandas) from 1.5.2 to 2.2.3. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v1.5.2...v2.2.3) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.11.0 to 2.16.1. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/v2.16.1/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.11.0...v2.16.1) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scikit-learn](https://github.com/scikit-learn/scikit-learn) from 1.3.2 to 1.5.2. - [Release notes](https://github.com/scikit-learn/scikit-learn/releases) - [Commits](scikit-learn/scikit-learn@1.3.2...1.5.2) --- updated-dependencies: - dependency-name: scikit-learn dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pymatgen](https://github.com/materialsproject/pymatgen) from 2024.3.1 to 2024.5.31. - [Release notes](https://github.com/materialsproject/pymatgen/releases) - [Changelog](https://github.com/materialsproject/pymatgen/blob/master/docs/CHANGES.md) - [Commits](materialsproject/pymatgen@v2024.3.1...v2024.5.31) --- updated-dependencies: - dependency-name: pymatgen dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
ml-evs
force-pushed
the
ml-evs/deps-updates
branch
from
a6bed71
to
9a7c505
Compare
ml-evs
commented
Nov 17, 2024
| @@ -438,7 +438,7 @@ def fit_preset( | |||
| for i in range(n_splits): | |||
| best_5_idx = np.argsort(val_losses[:, i])[:5] | |||
| for idx in best_5_idx: | |||
| final_models += models[idx][i].model | |||
| final_models.extend(models[idx][i].models) | |||
There was a problem hiding this comment.
I really don't know why this didn't call test failures until now, I can't see any other changes that would have prevented this code from executing, plus the deps updates here are all unrelated
No idea how this wasn't triggered in the tests previously...
ml-evs
force-pushed
the
ml-evs/deps-updates
branch
from
e229282
to
96fb84d
Compare
|
Can't request @VicTrqt for review, but perhaps that would be helpful to have a quick look too? Maybe @VicTrqt can also be given write access @ppdebreuck so that he can review things? |
ppdebreuck
approved these changes
Nov 28, 2024
|
@VicTrqt has been added to help reviewing stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to bundle up various dependency upgrades and associated required fixes.