relase bytebuffer earlier

ppzqh · Feb 6, 2024 · 2720c2a · 2720c2a
1 parent 6555cf8
commit 2720c2a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/pkg/remote/codec/default_codec.go b/pkg/remote/codec/default_codec.go
@@ -195,7 +195,6 @@ func (c *defaultCodec) encodeMetaAndPayloadWithCRC32C(ctx context.Context, messa
 
 	// 1. encode payload and calculate crc32c checksum
 	newPayloadOut := remote.NewWriterBuffer(PayloadBufferSize)
-	defer newPayloadOut.Release(nil)
 
 	if err = me.EncodePayload(ctx, message, newPayloadOut); err != nil {
 		return err
@@ -207,6 +206,7 @@ func (c *defaultCodec) encodeMetaAndPayloadWithCRC32C(ctx context.Context, messa
 	} else {
 		payload, err = newPayloadOut.Bytes()
 	}
+	newPayloadOut.Release(err)
 	if err != nil {
 		return err
 	}

diff --git a/pkg/remote/default_bytebuf.go b/pkg/remote/default_bytebuf.go
@@ -36,7 +36,6 @@ func init() {
 }
 
 // NewWriterBuffer is used to create a defaultByteBuffer using the given size.
-// NOTICE: defaultByteBuffer is only used for testing.
 func NewWriterBuffer(size int) ByteBuffer {
 	return newWriterByteBuffer(size)
 }