-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOT Jit Compile Workaround #1064
base: master
Are you sure you want to change the base?
Conversation
Read value that could not be read by default implmentation
As a tangentially related remark, I'm using a similar exception catching mechanism in a different internal library, but I'm a bit worried by |
The real workaround would be to use RegisterFastColumnSetter (I have written a SourceGenerator that Generates the code for it). |
@praeclarum is there any chance this will be merged at some point? Using the latest sqlite-net with release builds for Xamarin.iOS is basically broken at the moment (which is a pity seeing the library is mentioned on https://learn.microsoft.com/en-us/xamarin/ios/data-cloud/data/using-sqlite-orm and the readme.md mentioning Xamarin.iOS as the initial target platform 😊 ) This PR seems like a reasonable fallback for iOS for now. And iOS library users wanting to benefit from the possible performance gains can still provide their own setter via RegisterFastColumnSetter (which could be manually written or generated like @inforithmics suggests). And even without custom fast column setters on iOS, no performance gain is also still better than not being able to use the current version at all 😉 |
Is there some Interest in this Pull Request. If there is some Interest I would update this pull request with a SourceGenerator that Generates the Code for Using the FastColumn Setters |
I would be interested to see this updated and merged, yes |
Is there any chance we will see this Pull Request being updated? |
This Pull request is a workaround for this Xamarin iOS AOT Bug.
xamarin/xamarin-macios#12545
There are two Fixes