Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC]: Support WebSocket connection upgrades #78

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[PoC]: Support WebSocket connection upgrades #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d10289
Support WebSocket connection upgrades
JayH5 Mar 14, 2018
a03534f
Merge branch 'develop' into websockets
JayH5 Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nginx/conf.d/django.conf.d/locations/root.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,9 @@ location / {
# incorrectly/maliciously.
proxy_set_header X-Forwarded-Protocol "";
proxy_set_header X-Forwarded-Ssl "";

# WebSocket support
proxy_http_version 1.1;
proxy_set_header Upgrade $upgrade;
proxy_set_header Connection $connection_upgrade;
}
17 changes: 17 additions & 0 deletions nginx/conf.d/django.conf.d/maps/connection_upgrade.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Ensure the necessary headers get passed through by Nginx when the connection
# is being upgraded to WebSockets. The 'Upgrade' and 'Connection' headers are
# considered 'hop-by-hop' headers (RFC 2068) and so are not forwarded by proxies
# by default. We *do* forward those headers *if* the 'Upgrade' header suggests
# that this connection is being upgraded to WebSockets.

map $http_upgrade $upgrade {
# Maps do case-insensitive matching
websocket $http_upgrade;
default "";
}

map $http_upgrade $connection_upgrade {
websocket $http_connection;
# By default Nginx sends a 'Connection: close' header, we keep doing that
default close;
}