[refactor]:signup_router #237
Conversation
There was a problem hiding this comment.
Hey , please do not run any code formatter on the codebase , and submit the PR . It changes lots of lines and make it very difficult to review the code . Just make changes to the required lines and format only that lines of code . By hand or select only that lines and format.
| @@ -153,9 +153,11 @@ router.post('/login', apiRequestAuthLoginValidator, async (req, res) => { | |||
| */ | |||
| router.post('/signup', apiRequestAuthSignupValidator, async (req, res) => { | |||
| try { | |||
| const parsedBody = emailPasswordObjectValidator.parse(req.body); | |||
| const reqClientData: IRequestAuthSignup = res.locals.reqClientData; | |||
| const parsedBody = emailPasswordObjectValidator.parse(reqClientData.body); | |||
There was a problem hiding this comment.
Why you are validating again if already validated , remove this line
| @@ -153,9 +153,11 @@ router.post('/login', apiRequestAuthLoginValidator, async (req, res) => { | |||
| */ | |||
| router.post('/signup', apiRequestAuthSignupValidator, async (req, res) => { | |||
| try { | |||
| const parsedBody = emailPasswordObjectValidator.parse(req.body); | |||
| const reqClientData: IRequestAuthSignup = res.locals.reqClientData; | |||
| const parsedBody = emailPasswordObjectValidator.parse(reqClientData.body); | |||
| const email = parsedBody.email; | |||
| @@ -153,9 +153,11 @@ router.post('/login', apiRequestAuthLoginValidator, async (req, res) => { | |||
| */ | |||
| router.post('/signup', apiRequestAuthSignupValidator, async (req, res) => { | |||
| try { | |||
| const parsedBody = emailPasswordObjectValidator.parse(req.body); | |||
| const reqClientData: IRequestAuthSignup = res.locals.reqClientData; | |||
| const parsedBody = emailPasswordObjectValidator.parse(reqClientData.body); | |||
| const email = parsedBody.email; | |||
| const password = parsedBody.password; | |||
There was a problem hiding this comment.
use reqClientData to get password
| error:'A account already exists with this email.' | ||
| } | ||
| error: 'A account already exists with this email.', | ||
| }; | ||
| res.status(500).json(response); |
There was a problem hiding this comment.
Status should be 409 same as response.
| error: error.issues[0]?.message | ||
| } | ||
| error: error.issues[0]?.message, | ||
| }; | ||
| return res.status(400).send(response); |
| } | ||
| const response: ApiResponse<null> = { | ||
| success: false, | ||
| status: 400, |
| const response: ApiResponse<null> = { | ||
| success: false, | ||
| status: 400, | ||
| error: error, |
There was a problem hiding this comment.
Do not return error object . Only "Something unexpected happened". like that
| success: false, | ||
| status: 400, | ||
| error: error, | ||
| }; | ||
| return res.status(400).send(response); |
i'm sorry. |
Okay. Is it related to English language or something else. 「わかりました。それは英語の言語に関連していますか、それとも別の何かですか。」 |
Not only is my English not good, but |
|
遅くなりすみません。 |
「確認してお知らせします。ありがとうございます。」 |
issue
# 230
content
This PR enhances the code structure by utilizing res.locals.reqClientData as the source for client data, removing direct access to req.body, req.query, andreq.params.