Refactoring google route #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // token is required | ||
| try { | ||
| // Validate the request body using the Zod schema | ||
| const parsedBody = await tokenObjectValidator.parseAsync(req.body); | ||
| const parsedBody = await tokenObjectValidator.parseAsync(res.locals.reqClientData); |
There was a problem hiding this comment.
No need to validate , already validated : res.locals.reqClientData. Just use properties directly from res.locals.reqClientData
| error:'Invalid token' | ||
| } | ||
| res.status(401).send(response); | ||
| sendGErrorResponse(res, 401, 'Invalid token'); |
There was a problem hiding this comment.
If you want to use helper function put that in utils.ts file in server folder.
| @@ -463,22 +463,27 @@ router.post('/magic_login', apiRequestAuthMagicLoginValidator, | |||
| * Signup with google | |||
| * POSTMAN_TODO : This route is waiting to be added to postman and documented | |||
| */ | |||
| router.post('/google', apiRequestAuthGoogleValidator, async (req, res) => { | |||
| // Helper function for sending error responses | |||
| const sendGErrorResponse = (res: any,status:number,error:string) => { | |||
There was a problem hiding this comment.
Do not write global helper function here . Put that in utils.ts file in server folder . But i request you not to use helper function for this .
| const response:ApiResponse<null> = { | ||
| success : false , | ||
| status : 400, | ||
| error:'Token is required and must be non-empty' |
There was a problem hiding this comment.
Use error message from ZOD
| return; | ||
| } | ||
| const response:ApiResponse<null> = { | ||
| success : false , | ||
| status : 400, |
There was a problem hiding this comment.
Status code should be 500 . Internal server error. Not 400.
| @@ -555,17 +546,12 @@ router.post('/google_login', apiRequestAuthGoogleLoginValidator, async (req, res | |||
| // token is required | |||
| try { | |||
| // Validate the request body using the Zod schema | |||
| const parsedBody = await tokenObjectValidator.parseAsync(req.body); | |||
| const parsedBody = await tokenObjectValidator.parseAsync(res.locals.reqClientData); | |||
There was a problem hiding this comment.
There is issue related to this route . Submit Your PR with that issue.
prasenjeet-symon
requested changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer Refactor "/google" Route for Improved Code Structure #233
Done changes as mentioned