Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Boost CMake usage #194

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Fix Boost CMake usage #194

merged 5 commits into from
Aug 8, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Aug 8, 2024

Main changes of this PR

  • Enable Boost policy
  • Fix linker errors when using boost from config

Author's checklist

  • I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
  • I added a test to cover the proposed changes in our test suite.
  • I updated the documentation in docs/README.md.
  • I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

@davidscn
Copy link
Member

davidscn commented Aug 8, 2024

Don't we need

find_package(Boost 1.74.0 REQUIRED CONFIG ...

also please add a changelog entry.

fsimonis
fsimonis commented Aug 8, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@davidscn davidscn merged commit fe77af0 into develop Aug 8, 2024
1 check passed
@davidscn davidscn deleted the fix-boost-cmake branch August 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidscn davidscn davidscn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsimonis @davidscn