Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch for v2.20 pre-release #109

Merged
merged 5 commits into from
Nov 16, 2022
Merged

New branch for v2.20 pre-release #109

merged 5 commits into from
Nov 16, 2022

Conversation

KyleDavisSA
Copy link
Contributor

This PR starts the procedure for the v2.20 release.

@boris-martin
Copy link
Collaborator

I assume we want to first merge the subcycling related PRs before actually updating ?

@KyleDavisSA
Copy link
Contributor Author

PR #105 right? PR #106 is still WIP.

@boris-martin
Copy link
Collaborator

I'd actually merge #106 almost as-is (so it fixes the bug but we have an output per time window instead of per step). It depends on 105 (If I remember right, it's been some time), but no major update is needed, AFAIK

@MakisH
Copy link
Member

MakisH commented Nov 16, 2022

Please also remember to update the documentation: https://precice.org/adapter-calculix-overview.html

@MakisH
Copy link
Member

MakisH commented Nov 16, 2022

Note that a few CI checks seem to be failing at the moment.

@KyleDavisSA
Copy link
Contributor Author

KyleDavisSA commented Nov 16, 2022

Tutorials tested:

The sub-cycling can be addressed within v2.20 as that has not been solved yet in v2.19.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perpendicular-flap OpenFOAM-CalculiX also runs for me. The code changes look reasonable.

@MakisH MakisH merged commit 6eeaf17 into develop Nov 16, 2022
@MakisH MakisH deleted the v2.20 branch November 16, 2022 16:27
boris-martin added a commit that referenced this pull request Nov 17, 2022
* Improved error message (for missing mesh) (#88)

* Added error message for missing faces mesh
* Improved error message for missing nodes mesh

* 2D simulations major overhaul (#92)

Fixed 2D simulations being unusable with Temperature BC. Arbitrary number of elements on the Z-axis is now allowed and handled assuming data independant of the Z-axis.

* Added Pressure ExchangeData, hexaedral elements and Modal Dynamic Modus (#91)

* Added Pressure ExchangeData, hexaedral elements and Modal Dynamic Modus

* Update dyna_precice.c

Co-authored-by: Matthias Freimuth <[email protected]>
Co-authored-by: Boris Martin <[email protected]>

* format

* Added warning of broken implicit coupling when using modal dynamic simulations

* Fixed mesh configuration 2D coupling with Face meshes (#94)

* Fixed mesh config for face mesh

* Removed dead code

* Fixed missing include

* Fixed crash when using face meshes and element IDs don't start to 0 (#95)

* Fixed crashing simulation when using face meshes and element IDs don't start to 0

* Typo

Co-authored-by: Ishaan Desai <[email protected]>

* Typo

Co-authored-by: Ishaan Desai <[email protected]>

* Typo

Co-authored-by: Ishaan Desai <[email protected]>

* Update adapter/CCXHelpers.h

Co-authored-by: Ishaan Desai <[email protected]>

* format

* reverted fallow-argument-mismatch

* format

Co-authored-by: Ishaan Desai <[email protected]>

* Revert "Fixed crash when using face meshes and element IDs don't start to 0 (#95)" (#96)

This reverts commit 9cfc0cf.

* Update packaging script to Ubuntu 22.04 LTS (#98)

* added ubuntu 22.04 to the list of OSes in Github action

* updated to 2 Ubuntu LTS only, added fflags

* fixed wrong distribution name

* added preivous Ubuntu non-LTS

* fixd missing os

* typo

* removed non LTS

* Fixed face mesh config(correct PR) (#97)

* Fixed crashing simulation when using face meshes and element IDs don't start to 0

* Typo

Co-authored-by: Ishaan Desai <[email protected]>

* Typo

Co-authored-by: Ishaan Desai <[email protected]>

* Typo

Co-authored-by: Ishaan Desai <[email protected]>

* Update adapter/CCXHelpers.h

Co-authored-by: Ishaan Desai <[email protected]>

Co-authored-by: Ishaan Desai <[email protected]>

* format

* format

* restored script

* Fixed implicit coupling in modal dynamic simulation. (#99)

* Fixed missing checkpointing

* fixed extra output in implicit coupling

* removed deprecated warnings

* Fixed crash when freeing unused pointers (#102)

* init NULL pointers

* Enable Static Step for FSI (#101)

* Update ccx_2.19.c

Enable basic Static Step

* Update ccx_2.19.c

* Update ccx_2.19.c

* Add error messages when reading invalid data in modal dynamic simulations (#103)

* registering modal dynamic

* added forbidden reading types to modal dynamic sims

* added actual error

* Update adapter/PreciceInterface.c

Co-authored-by: Gerasimos Chourdakis <[email protected]>

* Update adapter/PreciceInterface.h

Co-authored-by: Gerasimos Chourdakis <[email protected]>

Co-authored-by: Gerasimos Chourdakis <[email protected]>

* basic infrastructure for proper checkpointingin dyna_precice

* seemingly working implict + subcycling modal dynamic simulations

* Prototype output buffer

* added C API

* added missing function

* improved Buffer

* Actual usage of the buffer, seemingly working

* added short description of the buffer mechanism

* cleanup

* refactoring

* format

* removed dead code

* renamed for consistency

* no longer asking for length when loading data

* cleanup

* documentation

* removed apparently useless memcpy (#104)

* Make read/write data name parsing consistent (#108)

* Update for CalculiX v2.20 (#109)

Co-authored-by: Boris Martin <[email protected]>
Co-authored-by: MatthiasFreimuth <[email protected]>
Co-authored-by: Matthias Freimuth <[email protected]>
Co-authored-by: Boris Martin <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Kyle Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants