Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix issue 399 #407

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Hotfix issue 399 #407

merged 4 commits into from
Nov 21, 2023

Conversation

valentin-seitz
Copy link
Member

@valentin-seitz valentin-seitz commented Nov 20, 2023

Executing gh workflow run run_testsuite_manual.yml -f suites=fenics_test -f build_args="TUTORIALS_REF:hotfix-issue-399" -f loglevel=DEBUG -f systests_branch=hotfix-issue-399 --ref=hotfix-issue-399 now works.
This should fix #399

@valentin-seitz valentin-seitz marked this pull request as ready for review November 20, 2023 21:28
@valentin-seitz valentin-seitz self-assigned this Nov 21, 2023
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, at least the error is not there anymore, but I am not sure how to check that it is indeed checking out the right branch/commit.

.github/workflows/run_testsuite_workflow.yml Show resolved Hide resolved
@valentin-seitz
Copy link
Member Author

Seems to work, at least the error is not there anymore, but I am not sure how to check that it is indeed checking out the right branch/commit.

Since we basically restore a certain path from a given ref via the git checkout its not really easy to check it.
But if the git checkout command itself fails, python will throw an exception.
So: It should work or it will generate an Exception (which are still a bit hard to debug because we dont get the orignal stderr/stdout of the git subprocess).

@valentin-seitz valentin-seitz merged commit 2bec0af into develop Nov 21, 2023
7 of 10 checks passed
@MakisH MakisH deleted the hotfix-issue-399 branch November 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants