-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nutils solid participant #431
Conversation
This addition goes indeed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested this, but the changes make sense.
Merging to master is fine, but please remember backporting to develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could run the case, the results look reasonable and the code very clean. Thanks @gertjanvanzwieten 🙏
Let's directly merge this. We can still improve later (nonlinear model, second-order time integration).
I required to explicitly ...
pip3 install --user bottombar==2.1
Otherwise, I ran into precice/precice#1443
Patch was done here: evalf/bottombar@fd2dc3a
I will document on https://precice.org/adapter-nutils.html
Linter problem seems unrelated:
|
* add nutils solid participant * Add new nutils solver to README list --------- Co-authored-by: Benjamin Uekermann <[email protected]>
FYI, the solution to this is disabling the We already do that in develop: https://github.com/precice/tutorials/blob/develop/.markdownlint.json Since the |
This PR adds a solid participant compatible only with Nutils 8, formerly part of #429.
It's a draft for now because it was discovered that the system has more damping than reference results, potentially resulting from the fully implicit first order formulation. I will do some more testing in the coming days to try and sort this out.