Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code of oscillator #598

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Nov 22, 2024

Removes temporary and unused variables.

It may help to have a look at the file CONTRIBUTING.md for a few hints and guidelines. -->

ToDo:

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

Removes temporary and unused variables
@BenjaminRodenberg
Copy link
Member Author

@uekerman let's merge #597 first. I spotted some unused variables. Some other changes are maybe worth discussing. Would appreciate a second opinion on the changes if they really improve readability or not.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review November 27, 2024 15:10
Copy link
Collaborator

@NiklasVin NiklasVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I tested it with the runge_kutta-4 and radauIIA and they work fine

@BenjaminRodenberg BenjaminRodenberg merged commit 855ce61 into develop Nov 28, 2024
1 check passed
@BenjaminRodenberg BenjaminRodenberg deleted the simplify-code-oscillator branch November 28, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants