Skip to content

Commit

Permalink
[native] advance velox version
Browse files Browse the repository at this point in the history
  • Loading branch information
xiaoxmeng committed Nov 28, 2024
1 parent ad9429d commit 497f281
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 17 deletions.
16 changes: 9 additions & 7 deletions presto-native-execution/presto_cpp/main/PeriodicTaskManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ folly::StringPiece getCounterForBlockingReason(
return kCounterNumBlockedWaitForMemoryDrivers;
case velox::exec::BlockingReason::kWaitForConnector:
return kCounterNumBlockedWaitForConnectorDrivers;
case velox::exec::BlockingReason::kWaitForSpill:
return kCounterNumBlockedWaitForSpillDrivers;
case velox::exec::BlockingReason::kYield:
return kCounterNumBlockedYieldDrivers;
case velox::exec::BlockingReason::kNotBlocked:
Expand Down Expand Up @@ -333,16 +331,20 @@ void PeriodicTaskManager::updateTaskStats() {
RECORD_METRIC_VALUE(
kCounterNumTasksBytesProcessed, taskManager_->getBytesProcessed());
RECORD_METRIC_VALUE(
kCounterNumTasksRunning, taskNumbers[velox::exec::TaskState::kRunning]);
kCounterNumTasksRunning,
taskNumbers[static_cast<int>(velox::exec::TaskState::kRunning)]);
RECORD_METRIC_VALUE(
kCounterNumTasksFinished, taskNumbers[velox::exec::TaskState::kFinished]);
kCounterNumTasksFinished,
taskNumbers[static_cast<int>(velox::exec::TaskState::kFinished)]);
RECORD_METRIC_VALUE(
kCounterNumTasksCancelled,
taskNumbers[velox::exec::TaskState::kCanceled]);
taskNumbers[static_cast<int>(velox::exec::TaskState::kCanceled]));
RECORD_METRIC_VALUE(
kCounterNumTasksAborted, taskNumbers[velox::exec::TaskState::kAborted]);
kCounterNumTasksAborted,
taskNumbers[static_cast<int>(velox::exec::TaskState::kAborted)]);
RECORD_METRIC_VALUE(
kCounterNumTasksFailed, taskNumbers[velox::exec::TaskState::kFailed]);
kCounterNumTasksFailed,
taskNumbers[static_cast<int>(velox::exec::TaskState::kFailed)]);

const auto driverCounts = taskManager_->getDriverCounts();
RECORD_METRIC_VALUE(kCounterNumQueuedDrivers, driverCounts.numQueuedDrivers);
Expand Down
10 changes: 5 additions & 5 deletions presto-native-execution/presto_cpp/main/PrestoTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ namespace {

protocol::TaskState toPrestoTaskState(exec::TaskState state) {
switch (state) {
case exec::kRunning:
case exec::TaskState::kRunning:
return protocol::TaskState::RUNNING;
case exec::kFinished:
case exec::TaskState::kFinished:
return protocol::TaskState::FINISHED;
case exec::kCanceled:
case exec::TaskState::kCanceled:
return protocol::TaskState::CANCELED;
case exec::kFailed:
case exec::TaskState::kFailed:
return protocol::TaskState::FAILED;
case exec::kAborted:
case exec::TaskState::kAborted:
[[fallthrough]];
default:
return protocol::TaskState::ABORTED;
Expand Down
2 changes: 0 additions & 2 deletions presto-native-execution/presto_cpp/main/common/Counters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ void registerPrestoMetrics() {
DEFINE_METRIC(
kCounterNumBlockedWaitForConnectorDrivers,
facebook::velox::StatType::AVG);
DEFINE_METRIC(
kCounterNumBlockedWaitForSpillDrivers, facebook::velox::StatType::AVG);
DEFINE_METRIC(kCounterNumBlockedYieldDrivers, facebook::velox::StatType::AVG);
DEFINE_METRIC(kCounterNumStuckDrivers, facebook::velox::StatType::AVG);
DEFINE_METRIC(
Expand Down
2 changes: 0 additions & 2 deletions presto-native-execution/presto_cpp/main/common/Counters.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ constexpr folly::StringPiece kCounterNumBlockedWaitForMemoryDrivers{
"presto_cpp.num_blocked_wait_for_memory_drivers"};
constexpr folly::StringPiece kCounterNumBlockedWaitForConnectorDrivers{
"presto_cpp.num_blocked_wait_for_connector_drivers"};
constexpr folly::StringPiece kCounterNumBlockedWaitForSpillDrivers{
"presto_cpp.num_blocked_wait_for_spill_drivers"};
constexpr folly::StringPiece kCounterNumBlockedYieldDrivers{
"presto_cpp.num_blocked_yield_drivers"};
constexpr folly::StringPiece kCounterNumStuckDrivers{
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Submodule velox updated 90 files
+114 −0 .github/workflows/breeze.yml
+2 −3 .github/workflows/conbench_upload.yml
+5 −0 scripts/setup-adapters.sh
+1 −0 scripts/velox_env_linux.yml
+1 −0 scripts/velox_env_mac.yml
+1 −1 velox/benchmarks/QueryBenchmarkBase.cpp
+3 −0 velox/common/base/Counters.h
+14 −3 velox/common/file/FileSystems.cpp
+6 −0 velox/common/file/FileSystems.h
+0 −13 velox/common/file/tests/FaultyFile.cpp
+1 −97 velox/common/file/tests/FaultyFile.h
+55 −1 velox/common/file/tests/FaultyFileSystem.cpp
+39 −0 velox/common/file/tests/FaultyFileSystem.h
+174 −0 velox/common/file/tests/FaultyFileSystemOperations.h
+22 −0 velox/common/file/tests/FileTest.cpp
+15 −3 velox/connectors/hive/HiveConfig.cpp
+7 −4 velox/connectors/hive/HiveConfig.h
+2 −1 velox/connectors/hive/HiveConnectorUtil.cpp
+0 −1 velox/connectors/hive/storage_adapters/hdfs/HdfsFileSystem.cpp
+0 −1 velox/connectors/hive/storage_adapters/hdfs/HdfsReadFile.cpp
+0 −1 velox/connectors/hive/storage_adapters/hdfs/HdfsReadFile.h
+7 −4 velox/connectors/hive/tests/HiveConfigTest.cpp
+3 −3 velox/connectors/hive/tests/HiveConnectorUtilTest.cpp
+7 −0 velox/core/PlanNode.h
+10 −0 velox/core/QueryConfig.h
+2 −2 velox/docs/configs.rst
+4 −1 velox/docs/functions/presto/regexp.rst
+7 −2 velox/docs/functions/spark/regexp.rst
+3 −1 velox/docs/monitoring/metrics.rst
+110 −51 velox/dwio/common/Throttler.cpp
+26 −5 velox/dwio/common/Throttler.h
+163 −36 velox/dwio/common/tests/ThrottlerTest.cpp
+4 −4 velox/exec/Driver.cpp
+2 −0 velox/exec/Driver.h
+0 −13 velox/exec/HashBuild.cpp
+3 −6 velox/exec/HashBuild.h
+14 −10 velox/exec/HashJoinBridge.cpp
+32 −77 velox/exec/HashProbe.cpp
+6 −8 velox/exec/HashProbe.h
+3 −1 velox/exec/Operator.cpp
+1 −1 velox/exec/OperatorTraceScan.cpp
+16 −6 velox/exec/Task.cpp
+27 −2 velox/exec/Task.h
+27 −1 velox/exec/TaskStructs.h
+22 −8 velox/exec/TraceUtil.cpp
+6 −9 velox/exec/TraceUtil.h
+224 −146 velox/exec/tests/HashJoinTest.cpp
+2 −2 velox/exec/tests/LocalPartitionTest.cpp
+99 −0 velox/exec/tests/TaskTest.cpp
+43 −3 velox/exec/tests/TraceUtilTest.cpp
+6 −2 velox/exec/tests/utils/HiveConnectorTestBase.cpp
+6 −1 velox/exec/tests/utils/PlanBuilder.cpp
+4 −0 velox/exec/tests/utils/PlanBuilder.h
+1 −0 velox/experimental/breeze/CMakeLists.txt
+1 −3 velox/experimental/breeze/cmake/cuda.cmake
+1 −3 velox/experimental/breeze/cmake/hip.cmake
+1 −3 velox/experimental/breeze/cmake/sycl.cmake
+98 −96 velox/experimental/breeze/test/CMakeLists.txt
+2 −0 velox/experimental/breeze/test/generate.sh
+88 −0 velox/experimental/breeze/test/generated/algorithms/algorithm_test-cuda.cuh
+120 −0 velox/experimental/breeze/test/generated/algorithms/kernels-cuda.cuh
+160 −0 velox/experimental/breeze/test/generated/functions/function_test-cuda.cuh
+284 −0 velox/experimental/breeze/test/generated/functions/kernels-cuda.cuh
+1 −1 velox/experimental/breeze/test/test_fixture_generator.py
+87 −0 velox/functions/lib/Re2Functions.h
+2 −85 velox/functions/prestosql/RegexpReplace.h
+2 −0 velox/functions/prestosql/tests/RegexpReplaceTest.cpp
+53 −29 velox/functions/sparksql/RegexFunctions.cpp
+28 −1 velox/functions/sparksql/tests/RegexFunctionsTest.cpp
+9 −2 velox/tool/trace/AggregationReplayer.h
+9 −2 velox/tool/trace/FilterProjectReplayer.h
+1 −0 velox/tool/trace/HashJoinReplayer.cpp
+9 −2 velox/tool/trace/HashJoinReplayer.h
+10 −6 velox/tool/trace/OperatorReplayerBase.cpp
+3 −3 velox/tool/trace/OperatorReplayerBase.h
+9 −2 velox/tool/trace/PartitionedOutputReplayer.cpp
+1 −0 velox/tool/trace/PartitionedOutputReplayer.h
+3 −8 velox/tool/trace/TableScanReplayer.cpp
+8 −5 velox/tool/trace/TableScanReplayer.h
+8 −1 velox/tool/trace/TableWriterReplayer.h
+12 −6 velox/tool/trace/TraceReplayRunner.cpp
+1 −0 velox/tool/trace/TraceReplayRunner.h
+2 −1 velox/tool/trace/tests/AggregationReplayerTest.cpp
+24 −3 velox/tool/trace/tests/FilterProjectReplayerTest.cpp
+90 −9 velox/tool/trace/tests/HashJoinReplayerTest.cpp
+3 −1 velox/tool/trace/tests/PartitionedOutputReplayerTest.cpp
+24 −3 velox/tool/trace/tests/TableScanReplayerTest.cpp
+2 −0 velox/tool/trace/tests/TableWriterReplayerTest.cpp
+20 −0 velox/type/Filter.h
+8 −0 velox/type/tests/FilterTest.cpp

0 comments on commit 497f281

Please sign in to comment.