Add support for ALTER VIEW RENAME TO statement #23749

dmariamgeorge · 2024-09-30T11:24:56Z

Description

Add support for SQL statement ALTER VIEW <view_name> RENAME TO <new_view_name>.

Motivation and Context

Addresses issue: #23748

Impact

Support SQL statement ALTER VIEW <view_name> RENAME TO <new_view_name> in Iceberg connector.

Test Plan

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==
General Changes
* Add support for ``ALTER VIEW RENAME TO``. :pr:`23749`

Iceberg Connector Changes
* Add support for ``ALTER VIEW RENAME TO``. :pr:`23749`

github-actions · 2024-09-30T11:25:54Z

Codenotify: Notifying subscribers in CODENOTIFY files for diff b19167e...ce12a4a.

Notify	File(s)
@aditi-pandit	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@elharo	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@kaikalur	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@rschlussel	presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4

steveburnett · 2024-09-30T14:38:19Z

Consider adding documentation for this to https://prestodb.io/docs/current/connector/iceberg.html#sql-support.

steveburnett

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

agrawalreetika · 2024-09-30T17:24:21Z

Thanks for the PR.

I have a few suggestions -

I think we can add one commit about adding SQL statement support and different commits for support for ALTER VIEW RENAME support for each connector support along with their connector document updates about the support
Please add tests as well in respective connector support commits
We can add ALTER VIEW documentation along with 1st commit of SQL Statement support here https://prestodb.io/docs/current/sql.html
Also it would be good to add SQL statement support for ALTER VIEW [ IF EXISTS ] as well and its respective tests

presto-docs/src/main/sphinx/connector/iceberg.rst

presto-main/src/main/java/com/facebook/presto/execution/RenameViewTask.java

presto-main/src/main/java/com/facebook/presto/testing/LocalQueryRunner.java

ZacBlanco · 2024-11-05T21:35:21Z

@dmariamgeorge Can we split this into two commits like @agrawalreetika suggested? Once we have both commits I will also review

steveburnett · 2024-11-05T21:47:37Z

Minor nits of formatting suggested for the release note entry.

== RELEASE NOTES ==
General Changes
* Add support for ``ALTER VIEW RENAME TO``. :pr:`23749`

Iceberg Connector Changes
* Add support for ``ALTER VIEW RENAME TO``. :pr:`23749`

dmariamgeorge · 2024-11-06T05:56:34Z

@dmariamgeorge Can we split this into two commits like @agrawalreetika suggested? Once we have both commits I will also review

Sure @ZacBlanco. Working on the same.

dmariamgeorge · 2024-11-11T15:02:27Z

@dmariamgeorge Can we split this into two commits like @agrawalreetika suggested? Once we have both commits I will also review

Sure @ZacBlanco. Working on the same.

@ZacBlanco - I have split the commits as suggested by @agrawalreetika. Can you please take a look?

agrawalreetika

@dmariamgeorge Thank you for making the changes. LGTM

steveburnett

Thanks for the doc! Just a few formatting nits and such.

presto-docs/src/main/sphinx/sql.rst

presto-docs/src/main/sphinx/connector/iceberg.rst

presto-docs/src/main/sphinx/connector/memory.rst

presto-docs/src/main/sphinx/sql/alter-view.rst

hantangwangd

Thanks for this work, one little problem and some nits, otherwise looks good to me.

hantangwangd · 2024-11-14T03:53:00Z

...-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/file/FileHiveMetastore.java

-
-        Table table = getRequiredTable(metastoreContext, databaseName, tableName);
        getRequiredDatabase(metastoreContext, newDatabaseName);
-        if (isIcebergTable(table)) {
-            throw new PrestoException(NOT_SUPPORTED, "Rename not supported for Iceberg tables");
-        }


Is it OK to completely remove this check? As far as I know, there could still have problems with altering iceberg table names now, so should we just allow the iceberg view here? Any misunderstanding please let me know.

@hantangwangd - The class FileHiveMetastore.java is for testing, and it will only affect the test logic.

As I understand, it's not just for testing. When user set hive.metastore=file and set hive.metastore.catalog.dir to a local or hdfs path, they are indeed using FileHiveMetastore in their environment. Meanwhile, it's not a good idea to introduce additional problems in any code, even for code that is only used in testing.

Iceberg views created by hive catalog will have a table parameters presto_view=true, so I think we can check this parameter, let iceberg view to pass, and keep iceberg table as it is until we really support renaming iceberg table name in hive catalog. Do you think this makes sense?

Sure @hantangwangd.

hantangwangd · 2024-11-14T03:57:19Z

presto-parser/src/main/java/com/facebook/presto/sql/SqlFormatter.java

+                    .append(node.getSource())
+                    .append(" RENAME TO ")
+                    .append(node.getTarget());


Is it better to use formatName(node.getSource()) and formatName(node.getTarget) as in other places? Since formatName(...) use QualifiedName.originalParts while QualifiedName.toString() use QualifiedName.parts.

hantangwangd · 2024-11-14T03:58:14Z

presto-parser/src/main/java/com/facebook/presto/sql/tree/RenameView.java

+    @Override
+    public int hashCode()
+    {
+        return Objects.hash(source, target);


nit: miss exists

hantangwangd · 2024-11-14T03:58:33Z

presto-parser/src/main/java/com/facebook/presto/sql/tree/RenameView.java

+        return Objects.equals(source, o.source) &&
+                Objects.equals(target, o.target);


nit: miss exists

hantangwangd · 2024-11-14T03:58:47Z

presto-parser/src/main/java/com/facebook/presto/sql/tree/RenameView.java

+        return toStringHelper(this)
+                .add("source", source)
+                .add("target", target)
+                .toString();


nit: miss exists

ZacBlanco · 2024-11-14T15:26:46Z

presto-hive/src/main/java/com/facebook/presto/hive/security/SqlStandardAccessControl.java

+                context.getSource(),
+                Optional.empty(),
+                false,
+                HiveColumnConverterProvider.DEFAULT_COLUMN_CONVERTER_PROVIDER,


nit: static import

ZacBlanco · 2024-11-14T15:27:01Z

presto-hive/src/main/java/com/facebook/presto/hive/security/SqlStandardAccessControl.java

+    public void checkCanRenameView(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName viewName, SchemaTableName newViewName)
+    {
+        MetastoreContext metastoreContext = new MetastoreContext(
+                identity, context.getQueryId().getId(),


nit: split these arguments onto two lines

ZacBlanco · 2024-11-14T15:28:21Z

presto-hive/src/main/java/com/facebook/presto/hive/security/SystemTableAwareAccessControl.java

+    @Override
+    public void checkCanRenameView(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName viewName, SchemaTableName newViewName)
+    {
+        delegate().checkCanRenameView(transactionHandle, identity, context, viewName, newViewName);


this should be delegate, not delegate()

ZacBlanco · 2024-11-14T15:34:11Z

presto-iceberg/src/test/java/com/facebook/presto/iceberg/TestIcebergMetadataListing.java

+    {
+        assertQuerySucceeds("CREATE TABLE iceberg.test_schema.iceberg_test_table (_string VARCHAR, _integer INTEGER)");
+        assertUpdate("CREATE VIEW iceberg.test_schema.test_view_to_be_renamed AS SELECT * FROM iceberg.test_schema.iceberg_test_table");
+        assertUpdate("ALTER VIEW IF EXISTS iceberg.test_schema.test_view_to_be_renamed RENAME TO iceberg.test_schema.test_view_renamed");


Can we add a case without the IF EXISTS clause?

ZacBlanco · 2024-11-14T15:35:26Z

presto-main/src/main/java/com/facebook/presto/execution/RenameViewTask.java

+            throw new SemanticException(VIEW_ALREADY_EXISTS, statement, "Target view '%s' already exists", target);
+        }
+        if (!viewName.getCatalogName().equals(target.getCatalogName())) {
+            throw new SemanticException(NOT_SUPPORTED, statement, "View rename across catalogs is not supported");


We support renaming across schemas though? Does it make sense to rename across schemas? What if the source tables don't exist in the new schema?

ZacBlanco · 2024-11-14T15:41:30Z

presto-memory/src/test/java/com/facebook/presto/plugin/memory/TestMemorySmoke.java

@@ -185,6 +185,31 @@ public void testViews()
        assertQueryFails("DROP VIEW test_view", "line 1:1: View 'memory.default.test_view' does not exist");
    }

+    @Test
+    public void testRenameView()


Wondering if we should instead add these tests to AbstractTestDistributedQueries? This way all connectors which support views can run this and we don't need to duplicate code.

@ZacBlanco - The support for ALTER VIEW RENAME TO is implemented only for the Iceberg and Memory connectors. If we add a test for this in AbstractTestDistributedQueries, it is required to override it in each connector, so the test will not fail for the other connectors.

steveburnett

LGTM! (docs)

Pull updated branch, new local doc build, reviewed, looks good. Thanks!

…rg connector

…y connector

dmariamgeorge requested review from hantangwangd, ZacBlanco, a team, jaystarshot, feilong-liu and ClarenceThreepwood as code owners September 30, 2024 11:24

dmariamgeorge requested a review from presto-oss September 30, 2024 11:24

dmariamgeorge mentioned this pull request Sep 30, 2024

Add support for ALTER VIEW RENAME TO statement #23748

Open

dmariamgeorge force-pushed the alter_view_rename branch from 6f20ada to cae013d Compare September 30, 2024 16:58

dmariamgeorge requested review from steveburnett and elharo as code owners September 30, 2024 16:58

steveburnett previously approved these changes Sep 30, 2024

View reviewed changes

hantangwangd requested changes Oct 9, 2024

View reviewed changes

dmariamgeorge dismissed steveburnett’s stale review via cb96521 October 20, 2024 15:00

dmariamgeorge force-pushed the alter_view_rename branch 5 times, most recently from c3a6ed6 to b1a2ab6 Compare October 21, 2024 10:00

dmariamgeorge force-pushed the alter_view_rename branch 4 times, most recently from 4f1282b to 4cbfaee Compare November 11, 2024 13:46

dmariamgeorge force-pushed the alter_view_rename branch from 7331ea7 to 5b56c09 Compare November 13, 2024 09:10

dmariamgeorge requested review from agrawalreetika and hantangwangd November 13, 2024 11:09

agrawalreetika previously approved these changes Nov 13, 2024

View reviewed changes

dmariamgeorge requested a review from steveburnett November 13, 2024 13:50

steveburnett requested changes Nov 13, 2024

View reviewed changes

hantangwangd requested changes Nov 14, 2024

View reviewed changes

ZacBlanco requested changes Nov 14, 2024

View reviewed changes

dmariamgeorge dismissed agrawalreetika’s stale review via c0e1953 November 18, 2024 17:06

dmariamgeorge force-pushed the alter_view_rename branch from 206a4aa to c0e1953 Compare November 18, 2024 17:06

steveburnett previously approved these changes Nov 18, 2024

View reviewed changes

dmariamgeorge dismissed steveburnett’s stale review via 3962882 November 19, 2024 05:28

dmariamgeorge force-pushed the alter_view_rename branch 5 times, most recently from 7773b97 to e566492 Compare November 19, 2024 15:21

dmariamgeorge requested review from hantangwangd and ZacBlanco November 20, 2024 06:56

dmariamgeorge force-pushed the alter_view_rename branch 7 times, most recently from b524a99 to 0f8daf1 Compare November 22, 2024 07:50

dmariamgeorge added 3 commits November 22, 2024 13:30

Add support for ALTER VIEW [ IF EXISTS ] RENAME TO statement

f5c9731

Add support for ALTER VIEW [ IF EXISTS ] RENAME TO statement in Icebe…

98482bb

…rg connector

Add support for ALTER VIEW [ IF EXISTS ] RENAME TO statement in Memor…

ce12a4a

…y connector

dmariamgeorge force-pushed the alter_view_rename branch from 0f8daf1 to ce12a4a Compare November 22, 2024 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ALTER VIEW RENAME TO statement #23749

Add support for ALTER VIEW RENAME TO statement #23749

dmariamgeorge commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

steveburnett commented Sep 30, 2024

steveburnett left a comment

agrawalreetika commented Sep 30, 2024 •

edited

Loading

ZacBlanco commented Nov 5, 2024

steveburnett commented Nov 5, 2024

dmariamgeorge commented Nov 6, 2024

dmariamgeorge commented Nov 11, 2024

agrawalreetika left a comment

steveburnett left a comment

hantangwangd left a comment

hantangwangd Nov 14, 2024

dmariamgeorge Nov 18, 2024

hantangwangd Nov 20, 2024

dmariamgeorge Nov 22, 2024

hantangwangd Nov 14, 2024

hantangwangd Nov 14, 2024

hantangwangd Nov 14, 2024

hantangwangd Nov 14, 2024

ZacBlanco Nov 14, 2024

ZacBlanco Nov 14, 2024

ZacBlanco Nov 14, 2024

ZacBlanco Nov 14, 2024

ZacBlanco Nov 14, 2024

ZacBlanco Nov 14, 2024

dmariamgeorge Nov 18, 2024

steveburnett left a comment

		return Objects.equals(source, o.source) &&
		Objects.equals(target, o.target);

Add support for ALTER VIEW RENAME TO statement #23749

Are you sure you want to change the base?

Add support for ALTER VIEW RENAME TO statement #23749

Conversation

dmariamgeorge commented Sep 30, 2024 • edited Loading

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

github-actions bot commented Sep 30, 2024 • edited Loading

steveburnett commented Sep 30, 2024

steveburnett left a comment

Choose a reason for hiding this comment

agrawalreetika commented Sep 30, 2024 • edited Loading

ZacBlanco commented Nov 5, 2024

steveburnett commented Nov 5, 2024

dmariamgeorge commented Nov 6, 2024

dmariamgeorge commented Nov 11, 2024

agrawalreetika left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

hantangwangd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

dmariamgeorge commented Sep 30, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading

agrawalreetika commented Sep 30, 2024 •

edited

Loading