Upgrade to JDK 21 w/ Java 17 Bytecode #23979
Draft
+6,788
−5,760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaneja
force-pushed
the
upgradeJava17Bytecode
branch
from
d7bd99b
to
d1931d9
Compare
6 tasks
ZacBlanco
force-pushed
the
upgradeJava17Bytecode
branch
4 times, most recently
from
476b65d
to
7234d24
Compare
There are a large number of parameters passed to argLine through the airbase POM. Set the airbase-specific props instead to aid in test failures
It seems later JVMs have drasitically improved their String representations. However, the string test is a bit of a wash because the estimated size entirely depends upon the strings which are used as input to the sketch. I think it's ok for this test to not be accurate for string-typed arguments for now.
CI actions seem to fail due to this line: https://github.com/apache/spark/blob/866816eb97002863ec205d854e1397982aecbc5e/core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala#L70-L71 Attempting to access an item from sun.security.action
For future, we can leave this as the default (true), but for testing on the PR we want to see both actions run
to one that uses JDK 17
Temp change to limit the errors from using a JDK 17 only image
…-test-coverage provisio-maven-plugin fails for presto-server without including the above when building presto-test-coverage
imjalpreet
force-pushed
the
upgradeJava17Bytecode
branch
from
15185b2
to
5e90e62
Compare
aaneja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: