-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native] Disable plan validation failure for timestamp with timezone and ipaddress types for native execution. #24040
base: master
Are you sure you want to change the base?
Conversation
Should we also delete the code |
Agree. We should remove the code as well. It doesn't provide any value anymore. We can re-add it if we want to bring the config back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amitkdutta! The failing e2e tests with IpAddress
and TimestampWithTimeZone
types in presto-native-tests
are running successfully with this fix.
@tdcmeehan @aditi-pandit Yes, will delete |
bc36e26
to
54a4fac
Compare
…and ipaddress types for native execution.
Description
As native engine now supports timestamp with timezone and ipaddress types, no need to make queries fail with plan validation by default. This change disables such validation failures by default.
Motivation and Context
Keeping timestamp and ipaddress by default enabled like java engine.
Impact
No new impact. If a production system explicitly set these configs, now they can remove those as default is enabled.
Test Plan
Updated existing tests.