Complete iceberg support for time type #24091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auden-woolfson
requested review from
sdruzkin,
a team,
hantangwangd and
ZacBlanco
as code owners
ethanyzhang
requested review from
a team and
ScrapCodes
and removed request for
a team
auden-woolfson
force-pushed
the
oss_time_testing
branch
from
d761fc0
to
717735c
Compare
sdruzkin
previously approved these changes
Nov 23, 2024
| @@ -186,6 +196,8 @@ private Block readNullBlock(boolean[] isNull, int nonNullCount) | |||
| throw new VerifyError("Unsupported type " + type); | |||
| } | |||
|
|
|||
| protected void maybeTransformValues(long[] values, int nextBatchSize) {} | |||
There was a problem hiding this comment.
Actually I don't think we do here... just took this directly from the IBM code. Will push version without it
auden-woolfson
force-pushed
the
oss_time_testing
branch
from
ba62319
to
f5e2b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing this functionality from IBM's repository. Added support for partitioning over the time type in orc files through the iceberg connector