Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Fix unused variable error #24117

Merged
merged 1 commit into from
Nov 23, 2024
Merged

[native] Fix unused variable error #24117

merged 1 commit into from
Nov 23, 2024
+0 −1

Conversation

HeidiHan0000
Copy link
Contributor

Summary:
Some builds were failing due to this unused variable which was imported as part of D65695576.
https://www.internalfb.com/sandcastle/workflow/3868592079916467326

Differential Revision: D66350671

@HeidiHan0000 HeidiHan0000 requested a review from a team as a code owner November 22, 2024 07:12
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D66350671

@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D66350671

@tdcmeehan tdcmeehan added the from:Meta PR from Meta label Nov 22, 2024
@prestodb-ci
Copy link

Saved that user @HeidiHan0000 is from Meta

@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D66350671

HeidiHan0000 added a commit to HeidiHan0000/presto that referenced this pull request Nov 22, 2024
@HeidiHan0000 @facebook-github-bot
Fix unused variable error (prestodb#24117)
9306a9a 
Summary:

Some builds were failing due to this unused variable which was imported as part of D65695576.
https://www.internalfb.com/sandcastle/workflow/3868592079916467326

Reviewed By: yuandagits

Differential Revision: D66350671
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D66350671

1 similar comment
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D66350671

@amitkdutta amitkdutta changed the title Fix unused variable error [native] Fix unused variable error Nov 22, 2024
@amitkdutta
Copy link
Contributor

amitkdutta commented Nov 22, 2024 •
edited
Loading

Thanks @HeidiHan0000. Please add "[native]" prefix in C++ worker related changes. Added in this one. Also add the prefix in commit message and submit again.

amitkdutta
amitkdutta approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

HeidiHan0000 added a commit to HeidiHan0000/presto that referenced this pull request Nov 22, 2024
@HeidiHan0000
[native] Fix unused variable error (prestodb#24117)
5a36bea 
Summary:

Some builds were failing due to this unused variable which was imported as part of D65695576.
https://www.internalfb.com/sandcastle/workflow/3868592079916467326

Reviewed By: yuandagits

Differential Revision: D66350671
@facebook-github-bot
Copy link
Collaborator

@HeidiHan0000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HeidiHan0000 @facebook-github-bot
[native] Fix unused variable error (prestodb#24117)
ee3892f 
Summary:
Some builds were failing due to this unused variable which was imported as part of D65695576.
https://www.internalfb.com/sandcastle/workflow/3868592079916467326


Reviewed By: yuandagits

Differential Revision: D66350671

Pulled By: HeidiHan0000
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D66350671

@facebook-github-bot facebook-github-bot merged commit 0c5fe5a into prestodb:master Nov 23, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkdutta amitkdutta amitkdutta approved these changes

Assignees
No one assigned
Labels
fb-exported from:Meta PR from Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HeidiHan0000 @facebook-github-bot @prestodb-ci @amitkdutta @tdcmeehan