[native] cache.no_retention should also be false when hive.node_selection_strategy=HARD_AFFINITY #24147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
sh-shamsan and
czentgr
and removed request for
a team
yingsu00
reviewed
Nov 26, 2024
There was a problem hiding this comment.
@minhancao Can you please clean up the release note section?
yingsu00
previously approved these changes
Nov 26, 2024
zuyu
reviewed
Nov 27, 2024
| @@ -117,7 +117,9 @@ void updateVeloxConnectorConfigs( | |||
| auto it = connectorConfig.find("node_selection_strategy"); | |||
| if (it != connectorConfig.end()) { | |||
| connectorConfig[connector::hive::HiveConfig::kCacheNoRetentionSession] = | |||
| it->second == "SOFT_AFFINITY" ? "false" : "true"; | |||
| (it->second == "SOFT_AFFINITY" || it->second == "HARD_AFFINITY") | |||
There was a problem hiding this comment.
how about it->second != "SOFT_AFFINITY" && it->second != "HARD_AFFINITY"?
There was a problem hiding this comment.
Changing logic to:
connectorConfig[connector::hive::HiveConfig::kCacheNoRetentionSession] =
(it->second != "SOFT_AFFINITY" && it->second != "HARD_AFFINITY") ? "true" : "false";
minhancao
force-pushed
the
hard_affinity_cache_retention
branch
from
fcd074c
to
6f34571
Compare
…tegy=HARD_AFFINITY
zuyu
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PR below allows setting hive.node_selection_strategy=SOFT_AFFINITY to set cache.no_retention=FALSE.
#24076
This PR adds setting hive.node_selection_strategy=HARD_AFFINITY will set cache.no_retention=FALSE as well.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.