[native] Add LinuxMemoryChecker check/warning to ensure system-mem-limit-gb is reasonably set #24149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
psnv03 and
pramodsatya
and removed request for
a team
minhancao
changed the title
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
from
4478ae1
to
15f55bb
Compare
minhancao
changed the title
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
from
15f55bb
to
7646600
Compare
…ystem-mem-limit-gb < actual total memory capacity.
czentgr
reviewed
Nov 27, 2024
| void start() { | ||
| // Set memMaxFile to "/sys/fs/cgroup/memory/memory.limit_in_bytes" for | ||
| // cgroup v1 or "sys/fs/cgroup/memory.max" for cgroup v2. | ||
| struct stat buffer; |
There was a problem hiding this comment.
Do we need to re-declare this as a struct here?
There was a problem hiding this comment.
Tried declaring it as stat buffer; and got error:
/root/presto/presto-native-execution/./presto_cpp/main/LinuxMemoryChecker.cpp:30:9: error: expected ‘;’ before ‘buffer’
30 | stat buffer;
| int64_t actualTotalMemory = 0; | ||
| folly::gen::byLine("/proc/meminfo") | | ||
| [&](const folly::StringPiece& line) -> void { | ||
| if (actualTotalMemory == 0) { |
There was a problem hiding this comment.
We don't need this check because we return immediately if it is set on line 79.
| }; | ||
| } | ||
|
|
||
| VELOX_CHECK_LT( |
There was a problem hiding this comment.
We should allow less or equal.
| return; | ||
| } | ||
| }; | ||
| if (memMaxFile != "None") { |
There was a problem hiding this comment.
We might need to add a comment here as to what the content could be for the maxMemFile. Since we check for the "max" keyword too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add LinuxMemoryChecker check and warning to ensure system-memory-gb < system-mem-limit-gb < actual total memory capacity.
For cgroup v1:
Set actual total memory to be the smaller number between /proc/meminfo and memory.limit_in_bytes
For cgroup v2:
Set actual total memory to be the smaller number between /proc/meminfo and memory.max
If memory.max contains "max" string, then look at /proc/meminfo for the MemTotal, otherwise use the value in memory.max.
VELOX_CHECK_LT(system-mem-limit-gb, actual total memory capacity):
Warning to output to worker's log:
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.