Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to not enforce input partition for join build #24163

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

feilong-liu
Copy link
Contributor

@feilong-liu feilong-liu commented Nov 27, 2024

Description

In presto java, we need the input of the join build to be partitioned by the join keys. However, @xiaoxmeng mentioned that it's not required for presto cpp. In this PR I add an options to so that this local exchange can be avoided.

Motivation and Context

As title

Impact

Avoid redundant local exchange

Test Plan

Existing tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add an session property to not enforce input partition for join build :pr:`24163`

@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Nov 27, 2024
@feilong-liu feilong-liu marked this pull request as draft November 27, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants