Fix serializer deleting the actual validation object's settings

pretagov · Dec 20, 2023 · 97b1815 · 97b1815
1 parent 94cd023
commit 97b1815
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/collective/volto/formsupport/restapi/deserializer/__init__.py b/src/collective/volto/formsupport/restapi/deserializer/__init__.py
@@ -57,9 +57,12 @@ def _expand_validation_field(self, field):
 
         for validation_id, validation in matched_validation_definitions:
             settings = vars(validation)["_settings"]
-            for ignored_setting in IGNORED_VALIDATION_DEFINITION_ARGUMENTS:
-                if ignored_setting in settings:
-                    del settings[ignored_setting]
+            settings = {
+                k: v
+                for k, v in settings.items()
+                for ignored_setting in IGNORED_VALIDATION_DEFINITION_ARGUMENTS
+                if ignored_setting not in settings
+            }
             field[validation_id] = settings
 
         # if api.user.has_permission("Modify portal content", obj=self.context):