Improve compatibility for inline alignment of table cells with variou…

…s email clients (collective#43) * Inline alignment to improve compatibility with various email clients * Fix tests
pretagov · Jan 9, 2024 · ebb70e5 · ebb70e5
1 parent 4edbe86
commit ebb70e5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/src/collective/volto/formsupport/browser/send_mail_template_table.pt b/src/collective/volto/formsupport/browser/send_mail_template_table.pt
@@ -12,9 +12,11 @@
     <caption i18n:translate="send_mail_text_table">Form submission data for ${title}</caption>
     <thead>
       <tr role="row">
-        <th scope="col"
+        <th align="left"
+          scope="col"
           role="columnheader">Field</th>
-        <th scope="col"
+        <th align="left"
+          scope="col"
           role="columnheader">Value</th>
       </tr>
     </thead>
@@ -23,9 +25,10 @@
         <tr role="row"
           tal:define="value field/value|nothing;
                       label field/label|nothing">
-          <th scope="row"
+          <th align="left"
+            scope="row"
             role="rowheader">${label}</th>
-          <td>${value}</td>
+          <td align="left">${value}</td>
         </tr>
       </tal:field>
     </tbody>

diff --git a/src/collective/volto/formsupport/tests/test_send_action_form.py b/src/collective/volto/formsupport/tests/test_send_action_form.py
@@ -743,25 +743,25 @@ def test_email_body_formated_as_table(
         self.assertIn(
             """<thead>
       <tr role="row">
-        <th scope="col" role="columnheader">Field</th>
-        <th scope="col" role="columnheader">Value</th>
+        <th align="left" scope="col" role="columnheader">Field</th>
+        <th align="left" scope="col" role="columnheader">Value</th>
       </tr>
     </thead>""",
             msg,
         )
 
         self.assertIn(
             """<tr role="row">
-          <th scope="row" role="rowheader">Name</th>""",
+          <th align="left" scope="row" role="rowheader">Name</th>""",
             msg,
         )
-        self.assertIn(f"<td>{name}</td>", msg)
+        self.assertIn(f'<td align="left">{name}</td>', msg)
         self.assertIn(
             """<tr role="row">
-          <th scope="row" role="rowheader">""",
+          <th align="left" scope="row" role="rowheader">""",
             msg,
         )
-        self.assertIn(f"<td>{message}</td>", msg)
+        self.assertIn(f'<td align="left">{message}</td>', msg)
 
     def test_email_body_formated_as_list(
         self,