Support TS4.9 satisfies operator
#13764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
sosukesuzuki
commented
Oct 30, 2022
| (node.type === "TSTypeAssertion" || | ||
| node.type === "TSAsExpression" || | ||
| // babel-parser cannot parse `satisfies` operator in left side of assignment | ||
| // https://github.com/babel/babel/issues/15095 |
fisker
reviewed
Oct 30, 2022
src/language-js/needs-parens.js
Outdated
Comment on lines
234
to
240
| case "TSAsExpression": | ||
| // example: foo as unknown as Bar | ||
| return node.type !== "TSAsExpression"; | ||
|
|
||
| case "TSSatisfiesExpression": | ||
| // example: foo satisfies unknown satisfies Bar | ||
| return node.type !== "TSSatisfiesExpression"; |
There was a problem hiding this comment.
Maybe mixed should not add parens either
Prettier pr-13764
Playground link
--parser babel-tsInput:
foo satisfies unknown satisfies Bar
foo as unknown as Bar
foo satisfies unknown as Bar
foo as unknown satisfies BarOutput:
foo satisfies unknown satisfies Bar;
foo as unknown as Bar;
(foo satisfies unknown) as Bar;
(foo as unknown) satisfies Bar;
fisker
reviewed
Oct 30, 2022
src/language-js/print/typescript.js
Outdated
| @@ -515,6 +515,8 @@ function printTypescript(path, options, print) { | |||
| return printJSDocType(path, print, /* token */ "!"); | |||
| case "TSInstantiationExpression": | |||
| return [print("expression"), print("typeParameters")]; | |||
| case "TSSatisfiesExpression": | |||
| return [print("expression"), " satisfies ", print("typeAnnotation")]; | |||
There was a problem hiding this comment.
Merge this into TSAsExpression too? There is an extra check there.
fisker
reviewed
Oct 30, 2022
src/language-js/needs-parens.js
Outdated
Comment on lines
241
to
244
| return ( | ||
| node.type !== "TSAsExpression" && | ||
| node.type !== "TSSatisfiesExpression" | ||
| ); |
There was a problem hiding this comment.
Suggested change
| return ( | |
| node.type !== "TSAsExpression" && | |
| node.type !== "TSSatisfiesExpression" | |
| ); | |
| return !isTSTypeExpression(node); |
fisker
reviewed
Oct 30, 2022
src/language-js/needs-parens.js
Outdated
Comment on lines
278
to
283
| (node.type === "TSTypeAssertion" || | ||
| node.type === "TSAsExpression" || | ||
| // babel-parser cannot parse `satisfies` operator in left side of assignment | ||
| // https://github.com/babel/babel/issues/15095 | ||
| // TODO: Add tests after the bug is fixed | ||
| node.type === "TSSatisfiesExpression") |
There was a problem hiding this comment.
We can reuse isTSTypeExpression here too.
fisker
approved these changes
Oct 30, 2022
|
FYI: @thorn0 may disagree to use |
|
Would it be possible to release this in 2.x? Upgrading to Prettier 3.0 may be more involved, so another 2.x release will allow folks to support TS 4.9 much faster.
|
|
It should not be easy, let's merge to |
2 tasks
|
This is great, thanks @sosukesuzuki 🙌 Will this be released in |
|
Maybe yes. |
When will it be released? |
|
@hiyangguo please follow #13792 and #13813 for progress. |
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 4, 2024
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 6, 2024
* Print `satisfies` operators * Add tests * Add changelog * Add `hug-args` tests * Add more tests for TSAsExpression * Add tests for argument expansion * Add tests for template literal * Add tests for ternary * Add tests for export default satisfies * Add tests for no lookahead tokens * Add more tests for needs parens 1 * Add more tests for needs-parens 2 * Add more tests for needs parens 3 * Add tests for needs parens 4 * Add comment * Add more tests for needs parens 5 * Add more tests for needs parens 6 * Fix test cases * Fix snapshots * Fix unstable tests * No parens for mixed * Merge printing logic * More reuse `isTSTypeExpression`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
babel-tsparser onlyPartial of #13516
Ref #13750
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨