Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more robust computation of git directory #183

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 17, 2024

Thanks for @ciyer

close #163

related #90 and #92

@JounQin JounQin added the bug Something isn't working label Jan 17, 2024
@JounQin JounQin self-assigned this Jan 17, 2024
Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 2240b56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pretty-quick Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
src/index.ts 955 B (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (93924ab) 88.60% compared to head (2240b56) 85.45%.

Files Patch % Lines
src/scms/git.ts 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   88.60%   85.45%   -3.16%     
==========================================
  Files           8        8              
  Lines         158      165       +7     
  Branches       46       49       +3     
==========================================
+ Hits          140      141       +1     
- Misses         15       21       +6     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin JounQin merged commit 71aab56 into master Jan 17, 2024
14 checks passed
@JounQin JounQin deleted the ciyer-computation branch January 17, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants