-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(#73/#125): add glob regex group cases #184
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 8 8
Lines 165 165
Branches 49 49
=======================================
Hits 141 141
Misses 21 21
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Great job! |
Co-authored-by: JounQin <[email protected]>
Closes #73
Closes #125
By replacing the
multimatch
withpicomatch
in #180, I accidentally fix #73 and #125 (multimatch
doesn't support regex grouping in the glob pattern, whilepicomatch
supports). The PR adds test cases to verify that both issues have been fixed.