Some changes regarding performance / memory #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bellian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
I just started to use this library and have some (hopefully) improvements for this lib.
Changes in
src/node.jswill reuse thebestGuessDistancehaving a minor impact on memory usage and performance benefit in chromium on big grids.Changes in
src/easystar.jsare improving the directional constraint checks.Directional constraints are represented in a bitfield instead of a string array.
A check if the field is accessable by the given direction is the performed by a simple
&operationsrc/easystar.js:475This should greatly improve the performance of directional constraints
Sadly there is no benchmark realy using directional constraints.
I am not shure about
src/easystar.js:478but it might also improve performance https://jsperf.com/for-loop-vs-indexofThe tests run smoothly and the benchmarks show a great improvement on larger grids.
I would be happy to discuss these changes.
Best
Bellian