Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PanelMenu(15403) - Submenu displays angledownicon when submenu is collapsed #16790

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mark7p
Copy link
Contributor

@mark7p mark7p commented Nov 20, 2024

Resolves #15403

Problem:: The logic from ngOnChanges() forces the component to create new processedItems with expanded: undefined.

Solution: Added check to keep expanded properties.

This is a possible solution for #16781 too, but I created another PR(#16791) with the fix for the hide animation.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 10:43am

Copy link

vercel bot commented Nov 20, 2024

@mark7p is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mark7p mark7p marked this pull request as draft November 20, 2024 10:40
@mark7p mark7p marked this pull request as ready for review November 20, 2024 10:46
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanelMenu nested subitems no longer get the expanded prop
2 participants