Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:16755 - dropdown emit event #16816

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix:16755 - dropdown emit event #16816

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e016ca3
Create npm-grunt.yml
mateuszstudentzero Oct 16, 2024
5016e36
create an index.html file
mateuszstudentzero Oct 16, 2024
17c8228
Update index.html
mateuszstudentzero Oct 16, 2024
a537ea0
Update index.html
mateuszstudentzero Oct 16, 2024
c86d1c5
Merge branch 'primefaces:master' into master
mateuszstudentzero Oct 17, 2024
080cadb
Fix: Add ripple effect to AccordionTab header
joaanyk Nov 22, 2024
c0f507e
Restore index.html
joaanyk Nov 22, 2024
421ad63
Fix: Dropdown respects emitEvent=false when setting value (#16755)
mateuszstudentzero Nov 22, 2024
0480490
Drop uneccessary changes
mateuszstudentzero Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/app/components/dropdown/dropdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,13 +1208,15 @@ export class Dropdown implements OnInit, AfterViewInit, AfterContentInit, AfterV
this.selectedOptionUpdated = true;
}

writeValue(value: any): void {
writeValue(value: any, emitEvent: boolean = true): void {
if (this.filter) {
this.resetFilter();
}

this.value = value;
this.allowModelChange() && this.onModelChange(value);
if (emitEvent && this.allowModelChange()) {
this.onModelChange(value);
}
this.modelValue.set(this.value);
this.updateEditableLabel();
this.cd.markForCheck();
Expand Down
Loading