Fix autocomplete updateOn blur on select (#16805) #16828
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Issue reported here #16805
Changes rationale
To handle
updateOn
setup withblur
value, the following changes have been made:onInputBlur
conditionally callingonModelTouched
only ifforceSelection
isfalse
.onModelTouched
call in theonSelect
( unconditionally ), which provides theFormControl
/FormGroup
the value selected by the user, without considering the text input the user is searching ( unless forceSelection is false ).Additional notes
This way was chosen because NG_VALUE_ACCESSOR updates the ancestor calling
registerOnTouched
which by angular docs:If
forceSelection
is set tofalse
andupdateOn
is set asblur
, upon both user input text / search and when user selects an option, theFormControl
andFormGroup
will be updated.