Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Band aid header #765

Closed
wants to merge 5 commits into from
Closed

Band aid header #765

wants to merge 5 commits into from

Conversation

dipree
Copy link
Contributor

@dipree dipree commented Apr 23, 2024

Making sure every page uses a layout with the much needed header instead of using anything from the template.

Re-did:

  • layout with toc but not a component
  • simple layout w/o toc (special treatment for source)
  • hero layout

@dipree dipree marked this pull request as ready for review April 23, 2024 19:00
@dipree dipree requested a review from a team as a code owner April 23, 2024 19:00
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question on the layouts, is it possible for us to use a default layout for these so we don't have to wrap each page? e.g. https://www.npmjs.com/package/gatsby-plugin-mdx/v/1.0.13#default-layouts or do we need to add explicit layouts for each page?

cc @camertron curious what you'd recommend 👀

@dipree
Copy link
Contributor Author

dipree commented Apr 24, 2024

@joshblack I tried that first but it's resulting in a number of errors when not making any other changes. It's also worth noting that all the component pages already use a layout, but not the "default" pages and some index pages had the index layout, some had not. But agreeing with you that it would be the better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants