Skip to content

Commit

Permalink
Update pull_request_template.md (#3344)
Browse files Browse the repository at this point in the history
* Update pull_request_template.md

* Add reminder for Storybook to merge checklist

* Reorder issue link in template

* Remove redundant sections in favor of linking issue to close

* Remove risk assessment section in favor of changelog and rollout strategy prompts

* Remove 'what approach did you use' section as this can be covered in the overview

* Remove heading

Co-authored-by: Josh Black <[email protected]>

* Update section title to "changelog & rollout strategy"

Co-authored-by: Josh Black <[email protected]>

* Fix heading levels for fourth-level headings

Co-authored-by: Josh Black <[email protected]>

* Remove redundant 'accessibility' section as we already run axe scans in CI

* Run formatter

---------

Co-authored-by: Josh Black <[email protected]>
  • Loading branch information
lesliecdubs and joshblack authored Sep 19, 2023
1 parent d988e47 commit 25fc058
Showing 1 changed file with 31 additions and 4 deletions.
35 changes: 31 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,42 @@
Describe your changes here.
<!-- Provide the GitHub issue that this issue closes. Start typing the number or name of the issue after the # below. -->

Closes # (type the issue number after # if applicable; otherwise remove this line)
Closes #

### Screenshots
<!-- Provide an overview of the changes, including before/after screenshots, videos, or graphs when helpful -->

Please provide before/after screenshots for any visual changes
### Changelog

<!-- Under the headings below, list out relevant API changes that this Pull Request introduces -->

#### New

<!-- List of things added in this PR -->

#### Changed

<!-- List of things changed in this PR -->

#### Removed

<!-- List of things removed in this PR -->

### Rollout strategy

<!-- How do you recommend this change to be rolled out? Refer to [contributor docs on Versioning](https://github.com/primer/react/blob/main/contributor-docs/versioning.md) for details. -->

- [ ] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan

### Testing & Reviewing

<!-- Describe any specific details to help reviewers test or review this Pull Request -->

### Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)
- [ ] Changes are [SSR compatible](https://github.com/primer/react/blob/main/contributor-docs/CONTRIBUTING.md#ssr-compatibility)
- [ ] Tested in Chrome
- [ ] Tested in Firefox
Expand Down

0 comments on commit 25fc058

Please sign in to comment.