-
Notifications
You must be signed in to change notification settings - Fork 538
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'next-major' into actionlist-br-hover
- Loading branch information
Showing
27 changed files
with
1,011 additions
and
855 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@primer/react': major | ||
--- | ||
|
||
Moves the new Dialog and ConfirmationDialog component to the drafts directory | ||
|
||
<!-- Changed components: Dialog --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,54 @@ | ||
{ | ||
"id": "drafts_dialog", | ||
"id": "dialog", | ||
"name": "Dialog", | ||
"status": "draft", | ||
"status": "alpha", | ||
"a11yReviewed": false, | ||
"stories": [], | ||
"props": [ | ||
{ | ||
"name": "title", | ||
"type": "React.ReactNode", | ||
"description": "Title of the Dialog. Also serves as the aria-label for this Dialog." | ||
"name": "isOpen", | ||
"type": "boolean", | ||
"description": "Whether or not the dialog is open" | ||
}, | ||
{ | ||
"name": "subtitle", | ||
"type": "React.ReactNode", | ||
"description": "The Dialog's subtitle. Optional. Rendered below the title in smaller type with less contrast. Also serves as the aria-describedby for this Dialog." | ||
"name": "onDismiss", | ||
"type": "() => void", | ||
"description": "Function that will be called when the dialog is closed" | ||
}, | ||
{ | ||
"name": "renderHeader", | ||
"type": "React.FunctionComponent<React.PropsWithChildren<DialogHeaderProps>>", | ||
"description": "Provide a custom renderer for the dialog header. This content is rendered directly into the dialog body area, full bleed from edge to edge, top to the start of the body element. Warning: using a custom renderer may violate Primer UX principles." | ||
"name": "returnFocusRef", | ||
"type": " React.RefObject<HTMLElement>", | ||
"description": "The element to restore focus back to after the `Dialog` is closed" | ||
}, | ||
{ | ||
"name": "renderBody", | ||
"type": "React.FunctionComponent<React.PropsWithChildren<DialogProps>>", | ||
"description": "Provide a custom render function for the dialog body. This content is rendered directly into the dialog body area, full bleed from edge to edge, header to footer. Warning: using a custom renderer may violate Primer UX principles." | ||
"name": "initialFocusRef", | ||
"type": " React.RefObject<HTMLElement>", | ||
"description": "Element inside of the `Dialog` you'd like to be focused when the Dialog is opened. If nothing is passed to `initialFocusRef` the close button is focused." | ||
}, | ||
{ | ||
"name": "renderFooter", | ||
"type": "React.FunctionComponent<React.PropsWithChildren<DialogProps>>", | ||
"description": "Provide a custom render function for the dialog footer. This content is rendered directly into the dialog footer area, full bleed from edge to edge, end of the body element to bottom. Warning: using a custom renderer may violate Primer UX principles." | ||
"name": "aria-labelledby", | ||
"type": "string", | ||
"description": "Pass an id to use for the aria-label. Use either a `aria-label` or an `aria-labelledby` but not both." | ||
}, | ||
{ | ||
"name": "footerButtons", | ||
"type": "DialogButtonProps[]", | ||
"description": "Specifies the buttons to be rendered in the Dialog footer." | ||
"name": "aria-label", | ||
"type": "string", | ||
"description": "Pass a label to be used to describe the Dialog. Use either a `aria-label` or an `aria-labelledby` but not both." | ||
}, | ||
{ | ||
"name": "onClose", | ||
"type": "(gesture: 'close-button' | 'escape') => void", | ||
"description": "This method is invoked when a gesture to close the dialog is used (either an Escape key press or clicking the 'X' in the top-right corner). The gesture argument indicates the gesture that was used to close the dialog (either 'close-button' or 'escape')." | ||
}, | ||
{ | ||
"name": "role", | ||
"type": "'dialog' | 'alertdialog'", | ||
"description": "The ARIA role to assign to this dialog." | ||
}, | ||
{ | ||
"name": "width", | ||
"type": "'small' | 'medium' | 'large' | 'xlarge'" | ||
}, | ||
{ | ||
"name": "height", | ||
"type": "'small' | 'large' | 'auto'" | ||
"name": "sx", | ||
"type": "SystemStyleObject" | ||
} | ||
], | ||
"subcomponents": [] | ||
"subcomponents": [ | ||
{ | ||
"name": "Dialog.Header", | ||
"props": [ | ||
{ | ||
"name": "sx", | ||
"type": "SystemStyleObject" | ||
} | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.