Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alphabetical ordering in the story name #3588

Closed
wants to merge 3 commits into from

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Aug 4, 2023

Describe your changes here.

Closes #2967

Updates the ordering of the stories from being alphabetical to the import order (order in the file)

  • Components are ordered alphabetically
  • Items under each component are ordered with a special order
  • Rest is ordered with the file order
Components
  Button
    Default
    Playground
    Children Playground
    Examples
      (these stories are ordered with the file order)
    Features
      (these stories are ordered with the file order)
    DevOnly
      (these stories are ordered with the file order)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

⚠️ No Changeset found

Latest commit: f9b3707

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.74 KB (0%)
dist/browser.umd.js 105.32 KB (0%)

],
],
],
'Drafts',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make the special order of 'Components' apply to the 'Drafts' as well. Any ideas how can I do that? 👀 cc @langermank

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you copy the exact thing from Components into Drafts?

[
            [
              '*',
              // Within a set of stories, set the order to the following
              ['*', 'Playground', /Playground$/, 'Features', 'Examples', 'DevOnly'],
            ],
          ],

@broccolinisoup broccolinisoup temporarily deployed to github-pages August 4, 2023 03:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3588 August 4, 2023 03:10 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages September 25, 2023 09:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3588 September 25, 2023 09:16 Inactive
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 10, 2024
@github-actions github-actions bot closed this Feb 17, 2024
@github-actions github-actions bot deleted the bs/storybook-sorting branch February 17, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook: Update the logic of sorting the stories
2 participants