Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump eslint-plugin-testing-library from 5.11.0 to 6.0.2 #3761

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-ssr-friendly": "1.2.0",
"eslint-plugin-storybook": "0.6.13",
"eslint-plugin-testing-library": "5.11.0",
"eslint-plugin-testing-library": "6.0.2",
"fast-glob": "3.3.1",
"filesize": "10.0.12",
"front-matter": "4.0.2",
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/SelectMenu.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ describe('SelectMenu', () => {
it('shows correct initial tab', () => {
const testInstance = renderRoot(<MenuWithTabs />)
// `findByProps` is a method on the renderer, not testing-library
// eslint-disable-next-line testing-library/await-async-query
// eslint-disable-next-line testing-library/await-async-queries
expect(testInstance.findByProps({'aria-selected': true}).props.children).toBe('Organization')
})

Expand All @@ -113,7 +113,7 @@ describe('SelectMenu', () => {
it('selected items have aria-checked', () => {
const testInstance = renderRoot(<BasicSelectMenu />)
// `findByProps` is a method on the renderer, not testing-library
// eslint-disable-next-line testing-library/await-async-query
// eslint-disable-next-line testing-library/await-async-queries
expect(testInstance.findByProps({'aria-checked': true}).props.children[1]).toBe('Primer Components bugs')
})

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/Textarea.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ describe('Textarea', () => {
expect(textareaElement.disabled).toEqual(true)
expect(textareaElement).toHaveAttribute('disabled')

user.click(textareaElement)
await user.click(textareaElement)

expect(handleChange).not.toHaveBeenCalled()

Expand Down
1 change: 1 addition & 0 deletions src/drafts/MarkdownEditor/MarkdownEditor.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const assertNotNull: <T>(t: T | null) => asserts t is T = t => expect(t).not.toB

const render = async (ui: React.ReactElement) => {
const result = _render(ui)
// eslint-disable-next-line testing-library/await-async-events
const user = userEvent.setup()

const getInput = () => result.getByRole('textbox') as HTMLTextAreaElement
Expand Down
Loading