Adds clear all button in header using the FilterRemoveIcon Octicon #3778

UnicodeRogue · 2023-09-28T18:19:46Z

Closes #2399

Changelog

New

No new files added, did add a new story, called I With Remove Filter Icon

Changed

Imported visual button FilterRemoveIcon and created the functionality to clear items selected in the drop-down list

Removed

One file was removed, the temporary icon that was a placeholder until the official Octicon one

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

changeset-bot · 2023-09-28T18:19:49Z

⚠️ No Changeset found

Latest commit: 604cb46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-09-28T18:23:26Z

size-limit report 📦

Path	Size
dist/browser.esm.js	104.71 KB (0%)
dist/browser.umd.js	105.28 KB (0%)

package.json

Co-authored-by: Gregor Martynus <[email protected]>

gr2m · 2023-09-28T20:30:17Z

examples/nextjs/package-lock.json

I'm not sure where the changes to examples/nextjs/package-lock.json came from. As far as I can tell we just ran npm install in the project root. Should we get the change removed from the PR?

Oh I'm okay to remove any changes 🙇🏻 You're right, what I know we didn't specifically work on I was thinking was coming through from the npm install/any updates around that

I don't think this is your fault, see #3776

siddharthkp · 2023-10-02T12:07:31Z

src/drafts/SelectPanel2/SelectPanel.tsx

@@ -1,5 +1,5 @@
 import React from 'react'
-import {SearchIcon, XCircleFillIcon, XIcon} from '@primer/octicons-react'
+import {SearchIcon, XCircleFillIcon, XIcon, FilterRemoveIcon} from '@primer/octicons-react'


siddharthkp · 2023-10-02T12:08:14Z

src/drafts/SelectPanel2/SelectPanel.stories.tsx

@@ -773,6 +773,64 @@ export const GOpenFromMenu = () => {
  )
 }

+export const IWithRemoveFilterIcon = () => {


Just checking, do we want to keep this story because clearSelection is also present in other stories

I believe so? If only because it will be easy to take out later if we want 🙇🏻

siddharthkp · 2023-10-02T12:10:27Z

package-lock.json

@@ -16,7 +16,7 @@
        "@lit-labs/react": "^1.1.1",
        "@oddbird/popover-polyfill": "0.2.2",
        "@primer/behaviors": "^1.3.4",
-        "@primer/octicons-react": "^19.7.0",
+        "@primer/octicons-react": "19.8.0",


Kinda odd that the lock file doesn't have a caret ^ anymore even though package.json does?

not having a ^ was the suggested format when I ran updates, but I agree that the lines read a bit weird. I'm going to pull in any recent changes and see if that resolves things

siddharthkp

Overall looks good! Left some small nit picks :)

Approving in advance

into UnicodeRogue-clear-all

UnicodeRogue · 2023-10-06T13:58:52Z

All right, working through the last few bits here- I do see three currently failing CI tests, mostly about ActionList- I wonder if this is something we can take out?

github-actions · 2023-10-06T13:59:04Z

Uh oh! @UnicodeRogue, the image you shared is missing helpful alt text. Check #3778 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

…stories

…, otherwise npm ci fails resolves https://github.com/primer/react/actions/runs/6449351303/job/17507571046\?pr\=3778

gr2m · 2023-10-08T18:47:48Z

examples/nextjs/package-lock.json

this changes was necessary to address https://github.com/primer/react/actions/runs/6449351303/job/17507571046?pr=3778

Adds clear all button in header

71c2646

UnicodeRogue temporarily deployed to github-pages September 28, 2023 18:27 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-3778 September 28, 2023 18:27 Inactive

UnicodeRogue marked this pull request as ready for review September 28, 2023 18:31

UnicodeRogue requested review from a team and joshblack September 28, 2023 18:31

gr2m added the skip changeset This change does not need a changelog label Sep 28, 2023

gr2m requested changes Sep 28, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

gr2m requested a review from siddharthkp September 28, 2023 18:34

Update package.json

06e6d66

Co-authored-by: Gregor Martynus <[email protected]>

UnicodeRogue temporarily deployed to github-pages September 28, 2023 19:42 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-3778 September 28, 2023 19:43 Inactive

gr2m approved these changes Sep 28, 2023

View reviewed changes

siddharthkp removed the request for review from joshblack October 2, 2023 09:39

siddharthkp reviewed Oct 2, 2023

View reviewed changes

siddharthkp approved these changes Oct 2, 2023

View reviewed changes

Merge branch 'main' into UnicodeRogue-clear-all

174f0ec

UnicodeRogue temporarily deployed to github-pages October 6, 2023 13:11 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-3778 October 6, 2023 13:12 Inactive

UnicodeRogue added 2 commits October 6, 2023 13:40

NPM updates

9992c0a

Merge branch 'UnicodeRogue-clear-all' of https://github.com/primer/react

09b4456

into UnicodeRogue-clear-all

UnicodeRogue temporarily deployed to github-pages October 6, 2023 13:51 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-3778 October 6, 2023 13:51 Inactive

Merge branch 'main' into UnicodeRogue-clear-all

473f091

gr2m temporarily deployed to github-pages October 8, 2023 18:36 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-3778 October 8, 2023 18:36 Inactive

use ActionList instead of SelectPanel.ActionList as in the other …

6b3e397

…stories

gr2m temporarily deployed to github-pages October 8, 2023 18:44 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-3778 October 8, 2023 18:44 Inactive

update examples/nextjs/package-lock.json to sync it with package.json…

604cb46

…, otherwise npm ci fails resolves https://github.com/primer/react/actions/runs/6449351303/job/17507571046\?pr\=3778

gr2m reviewed Oct 8, 2023

View reviewed changes

gr2m deployed to github-pages October 8, 2023 18:53 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-3778 October 8, 2023 18:53 View deployment

gr2m approved these changes Oct 8, 2023

View reviewed changes

gr2m added this pull request to the merge queue Oct 8, 2023

Merged via the queue into main with commit ae23932 Oct 8, 2023
30 checks passed

gr2m deleted the UnicodeRogue-clear-all branch October 8, 2023 20:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds clear all button in header using the FilterRemoveIcon Octicon #3778

Adds clear all button in header using the FilterRemoveIcon Octicon #3778

UnicodeRogue commented Sep 28, 2023 •

edited

Loading

changeset-bot bot commented Sep 28, 2023 •

edited

Loading

github-actions bot commented Sep 28, 2023 •

edited

Loading

gr2m Sep 28, 2023

UnicodeRogue Sep 29, 2023

siddharthkp Oct 2, 2023

siddharthkp Oct 2, 2023

siddharthkp Oct 2, 2023 •

edited

Loading

UnicodeRogue Oct 6, 2023

siddharthkp Oct 2, 2023 •

edited

Loading

UnicodeRogue Oct 6, 2023

siddharthkp left a comment

UnicodeRogue commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

gr2m Oct 8, 2023

Adds clear all button in header using the FilterRemoveIcon Octicon #3778

Adds clear all button in header using the FilterRemoveIcon Octicon #3778

Conversation

UnicodeRogue commented Sep 28, 2023 • edited Loading

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

changeset-bot bot commented Sep 28, 2023 • edited Loading

⚠️ No Changeset found

github-actions bot commented Sep 28, 2023 • edited Loading

size-limit report 📦

gr2m Sep 28, 2023

Choose a reason for hiding this comment

UnicodeRogue Sep 29, 2023

Choose a reason for hiding this comment

siddharthkp Oct 2, 2023

Choose a reason for hiding this comment

siddharthkp Oct 2, 2023

Choose a reason for hiding this comment

siddharthkp Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

UnicodeRogue Oct 6, 2023

Choose a reason for hiding this comment

siddharthkp Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

UnicodeRogue Oct 6, 2023

Choose a reason for hiding this comment

siddharthkp left a comment

Choose a reason for hiding this comment

UnicodeRogue commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

gr2m Oct 8, 2023

Choose a reason for hiding this comment

UnicodeRogue commented Sep 28, 2023 •

edited

Loading

changeset-bot bot commented Sep 28, 2023 •

edited

Loading

github-actions bot commented Sep 28, 2023 •

edited

Loading

siddharthkp Oct 2, 2023 •

edited

Loading

siddharthkp Oct 2, 2023 •

edited

Loading