-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move legacy primer/primitives
into Primer React
#3787
Conversation
🦋 Changeset detectedLatest commit: 3d43bf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
src/legacy-theme/js/colors/light.js
Outdated
@@ -0,0 +1,602 @@ | |||
const colors = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these files be .ts
with the variable set as const
? This could mean that the files are checked with TypeScript and we don't have to check-in the generated definition files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally! Thanks, will make that change 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshblack took a stab at converting it all to JS, can you give it a look? I don't totally know what I'm doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great! I think we just need to debug the integration PR failing and should be good to try out in our next release 👀
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Part of https://github.com/github/primer/issues/2054
As we gear up for Primitives v8 (next major) I'm looking for ways we can stopgap the breaking change to provide more time for Primer libraries to upgrade. This PR copies the
dist
that Primer React depends on directly into Primer React which allows us to remove it from Primitives. The only thing truly referenced from Primitives are colors, while most other values were hand written in the theme file.Goals:
Changelog
New
dist
fromprimer/primitives
and removes dependencyChanged
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.