Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to UnderlineNav default story #3793

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Add aria-label to UnderlineNav default story #3793

merged 2 commits into from
Oct 9, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Oct 6, 2023 •
edited
Loading

UnderlineNav default story throws an error in the dev env due to missing an aria-label attribute. This PR adds this.

@broccolinisoup broccolinisoup requested review from a team and siddharthkp October 6, 2023 00:15
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: db29b39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.71 KB (0%)
dist/browser.umd.js 105.28 KB (0%)

@broccolinisoup broccolinisoup temporarily deployed to github-pages October 6, 2023 00:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3793 October 6, 2023 00:21 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 953b609 Oct 9, 2023
30 checks passed
@broccolinisoup broccolinisoup deleted the bs/fix-underlinenav-default-story branch October 9, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broccolinisoup @joshblack