Add trailingVisualLabel to SegmentedControlButton #3807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0a1568 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Closing this out for now, but I may circle back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with primer/view_components#2278
Changelog
Sometimes it is useful to add a trailing label to items in the Segmented Control. One use case is displaying a discount when selecting between different billing intervals, eg "Monthly / Yearly (-8%)"
New
Adds an optional trailingVisualLabel to SegmentedControlButton. This expects a Label component
Changed
Removed
Rollout strategy
Testing & Reviewing
I've added tests and updated storybook examples, but let me know if there's anything else that I should be aware of.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.