Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back "refactor: remove MarkdownEditor and MarkdownViewer (#4782)"" #4868

Conversation

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 95a54b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 21, 2024
@siddharthkp siddharthkp changed the title Revert "Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)"" Bring back "refactor: remove MarkdownEditor and MarkdownViewer (#4782)"" Aug 21, 2024
@siddharthkp siddharthkp added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 21, 2024
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.2 KB (0%)
packages/react/dist/browser.umd.js 96.54 KB (0%)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/340366

@siddharthkp
Copy link
Member Author

Failing CI build: https://github.com/github/github/actions/runs/10698094302/job/29656790627?pr=340366#step:15:6109

NX   Running target tsc for 444 projects failed

Failed tasks:

- @github-ui/markdown-editor:tsc
- @github-ui/comment-box:tsc
- @github-ui/issue-form:tsc
- @github-ui/issue-create:tsc
- @github-ui/commenting:tsc
- @github-ui/issue-body:tsc
- @github-ui/sub-issues:tsc
- @github-ui/list-view-items-issues-prs:tsc
- @github-ui/issue-viewer:tsc
- @github-ui/copilot-reference-preview:tsc
- @github-ui/copilot-chat:tsc
- @github-ui/copilot-code-chat:tsc
- @github-ui/conversations:tsc
- @github-ui/diff-lines:tsc
- @github-ui/diff-file-tree:tsc
- @github-ui/commits:tsc
- @github-ui/global-create-menu:tsc
- @github-ui/app-assets-modules:tsc
- @github-ui/global-user-nav-drawer:tsc
- @github-ui/issue-create-element:tsc
- @github-ui/comment-editor:tsc
- @github-ui/pull-request-commits:tsc
- @github-ui/copilot-immersive:tsc
- @github-ui/notifications-inbox:tsc
- @github-ui/pull-request-viewer:tsc
- @github-ui/copilot-task:tsc
- @github-ui/issues-react:tsc
- @github-ui/memex:tsc

@joshblack
Copy link
Member

Closing in favor of: #4953

@joshblack joshblack closed this Sep 12, 2024
@joshblack joshblack deleted the revert-4860-revert-4782-refactor/remove-markdowneditor-markdownviewer branch September 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants