Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update AvatarStack component to use CSS modules behind the feature flag primer_react_css_modules_team" #5034

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Revert "Update AvatarStack component to use CSS modules behind the feature flag primer_react_css_modules_team" #5034

merged 2 commits into from
Sep 26, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Sep 26, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b2b598d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 26, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5034 September 26, 2024 15:39 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.95 KB (-0.2% 🔽)
packages/react/dist/browser.umd.js 98.4 KB (-0.24% 🔽)

@primer-integration
Copy link

primer-integration bot commented Sep 26, 2024 •
edited by siddharthkp
Loading

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344224

Update: It's green :)

@siddharthkp siddharthkp mentioned this pull request Sep 26, 2024
Closed
4 tasks
@siddharthkp siddharthkp marked this pull request as ready for review September 26, 2024 16:21
@siddharthkp siddharthkp requested a review from a team as a code owner September 26, 2024 16:21
@siddharthkp siddharthkp self-assigned this Sep 26, 2024
@siddharthkp
Copy link
Member Author

@jonrohan Sorry, found issues in the PR, so have to revert :(

@joshblack joshblack added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 198fc47 Sep 26, 2024
32 checks passed
@joshblack joshblack deleted the revert-5012-css_modules_avatar_stack branch September 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup broccolinisoup is a code owner automatically assigned from primer/engineer-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

@francinelucca francinelucca Awaiting requested review from francinelucca

Assignees

@siddharthkp siddharthkp

Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @joshblack