Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput: Add autoComplete to Storybook/docs #5051

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Sep 30, 2024

Closes https://github.com/github/primer/issues/3394

Utilizing the autocomplete attribute is tied to WCAG SC 1.3.5, and is essential for inputs that can be mapped to a valid autocomplete value. This PR adds a story and documentation for the autoComplete prop in the TextInput component to better surface this attribute. More context at primer/design#867.

Changelog

New

  • Adds autocomplete attribute to docs
  • Add specific story for autoComplete prop in TextInput

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 6bc4b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.1 KB (0%)
packages/react/dist/browser.umd.js 98.35 KB (0%)

@TylerJDev TylerJDev marked this pull request as ready for review September 30, 2024 16:45
@TylerJDev TylerJDev requested a review from a team as a code owner September 30, 2024 16:45
@TylerJDev TylerJDev added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 1612131 Sep 30, 2024
41 of 42 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/add-autocomplete-attr-textinput branch September 30, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants