Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dialog): Add stories and vrt tests for Dialog #5305

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

hussam-i-am
Copy link
Collaborator

@hussam-i-am hussam-i-am commented Nov 15, 2024

Relates to https://github.com/github/primer/issues/4309

Changelog

New

Changed

  • Adds dev stories for Dialog
  • Updates vrt test file for Dialog to new format and added dev stories

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Just updating test files, nothing to roll out

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 15, 2024
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 15, 2024 17:07
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: a2b0ff4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5305 November 15, 2024 17:10 Inactive
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100 KB (0%)
packages/react/dist/browser.umd.js 100.38 KB (0%)

@primer primer bot requested a review from a team as a code owner November 15, 2024 19:14
@primer primer bot requested a review from maximedegreve November 15, 2024 19:14
@github-actions github-actions bot temporarily deployed to storybook-preview-5305 November 15, 2024 19:17 Inactive
@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 736bd7b Nov 15, 2024
42 of 43 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/dialog-v2-tests branch November 15, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants