Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SelectPanel2): Convert SelectPanel2 to CSS modules #5325

Merged
merged 9 commits into from
Nov 25, 2024
Merged

feat(SelectPanel2): Convert SelectPanel2 to CSS modules #5325

merged 9 commits into from
Nov 25, 2024

Conversation

hussam-i-am
Copy link
Collaborator

Changelog

New

Changed

  • Converts SelectPanel to CSS modules without feature flag since it is only used internally and does not currently accept an sx or className prop

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 21, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 09de060

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5325 November 21, 2024 23:19 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.49 KB (0%)
packages/react/dist/browser.umd.js 102.85 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5325 November 21, 2024 23:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5325 November 21, 2024 23:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5325 November 22, 2024 00:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5325 November 22, 2024 00:27 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 22, 2024
@hussam-i-am hussam-i-am marked this pull request as ready for review November 22, 2024 16:08
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 22, 2024 16:08
francinelucca
francinelucca requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just one question around classNames.
I'm wondering if we want to rethink shipping under a FF, I do see this being pulled in from /experimental in dotcom unless I'm reading this wrong?

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5325 November 22, 2024 19:27 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@hussam-i-am
Copy link
Collaborator Author

@francinelucca Readded the sx props and update classNames to pass through from props

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 22, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352234

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

francinelucca
francinelucca approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! one non-blocking suggestion

packages/react/src/experimental/SelectPanel2/SelectPanel.tsx
<Box sx={{display: 'flex', alignItems: 'center', gap: 2}}>
<Checkbox id={checkboxId} sx={{marginTop: 0}} {...props} />
<InputLabel htmlFor={checkboxId} sx={{fontSize: 0}}>
<Box
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we render theses Boxes as native divs when enabled?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it defaults to a div and doesn't need it in those cases

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit cdc4da1 Nov 25, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/select-panel-2-css-modules branch November 25, 2024 16:04
@primer primer bot mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

Assignees

@hussam-i-am hussam-i-am

Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussam-i-am @francinelucca