Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PageHeader): Convert PageHeader to CSS modules behind feature flag #5332

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hussam-i-am
Copy link
Collaborator

Closes https://github.com/github/primer/issues/4300

Changelog

New

Changed

  • Adds CSS modules behind feature flag
  • Adds data attributes for when to hide on breakpoints

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 25, 2024
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 35ee676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 25, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.85 KB (+0.31% 🔺)
packages/react/dist/browser.umd.js 103.23 KB (+0.39% 🔺)

@hussam-i-am hussam-i-am marked this pull request as ready for review November 25, 2024 21:06
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 25, 2024 21:06
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352531

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 25, 2024
@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant