Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates label and legend styles for Checkbox, Radio, CheckboxGroup, and RadioGroup #5333

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updates label and legend styles for Checkbox, Radio, CheckboxGroup, and RadioGroup #5333

wants to merge 4 commits into from

Conversation

mperrotti
Copy link
Contributor

Closes #5311

Screenshots

Before

Screenshot 2024-11-25 at 5 02 11 PM

After

Screenshot 2024-11-25 at 5 01 45 PM

Changelog

New

Changed

  • Makes {Checkbox|Radio}Group <legend> bold and default font size
  • Makes Checkbox and Radio <label> default font weight

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner November 25, 2024 22:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9fe8082

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 25, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5333 November 25, 2024 22:09 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.72 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 102.96 KB (-0.06% 🔽)

@primer primer bot requested a review from a team as a code owner November 25, 2024 22:32
francinelucca
francinelucca reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise, just a few questions.
Also since this has the potential to touch a lot of areas indirectly, I'd recommend running the integration tests and doing some manual testing in RL to make sure everything still looks good

packages/react/src/FormControl/FormControl.tsx
@@ -172,17 +172,15 @@ const FormControl = React.forwardRef<HTMLDivElement, FormControlProps>(
{slots.leadingVisual}
</Box>
)}
{!slots.label?.props.visuallyHidden || slots.caption ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we don't need this check anymore?

packages/react/src/internal/components/InputLabel.tsx
@@ -54,7 +54,6 @@ const InputLabel: React.FC<React.PropsWithChildren<Props>> = ({
display: 'block',
color: disabled ? 'fg.muted' : 'fg.default',
cursor: disabled ? 'not-allowed' : 'pointer',
alignSelf: 'flex-start',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure this is an intended change? as it doesn't seem directly correlated with Checkbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca left review comments

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CheckboxGroup and RadioGroup don't pair well with FormControl due to missing size variants
2 participants
@mperrotti @francinelucca